9.0 website cms theme jne #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanNEMRY
commented
Oct 4, 2016
JonathanNEMRY
commented
- Add website_cms_theme
- Some pep8 issues
|
👍 |
added 3 commits
October 4, 2016 15:56
* provide a module to manage a theme by forms
simahawk
requested changes
Oct 5, 2016
Owner
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
Overall LGTM but need some updates. Furthermore: would you mind to add some screenshots? They could be usible for documentation too.
| <xpath expr="link[last()]" position="after"> | ||
| <link href="/website_cms_theme/static/src/less/layouts/form.less" | ||
| rel="stylesheet" type="text/less"/> | ||
| <link href="/website_cms_theme/static/src/less/assets/varriables.less" |
Owner
There was a problem hiding this comment.
this should be variables.less and the filename should change accordingly, of course ;)
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <!-- Assets, less, js --> | ||
| <template id="website_cms_them" name="Website CMS Theme" |
Owner
There was a problem hiding this comment.
website_cms_them -> you miss an 'e'
Owner
There was a problem hiding this comment.
also it's better to include "assets" both in the id and the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.