Improve alignment #387
Open
Improve alignment #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licenser
force-pushed
the
alignment-improvements
branch
2 times, most recently
from
15c04c8 to
ebab1d2
Compare
Benchmark for e9fee9fClick to view benchmark
|
Benchmark for dabe1afClick to view benchmark
|
Licenser
force-pushed
the
alignment-improvements
branch
from
07b6e66 to
83a4aec
Compare
Benchmark for 00d086fClick to view benchmark
|
Licenser
force-pushed
the
alignment-improvements
branch
from
83a4aec to
ce1d7e8
Compare
Benchmark for a10a17eClick to view benchmark
|
Licenser
force-pushed
the
alignment-improvements
branch
from
ce1d7e8 to
3aad36b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
===========================================
- Coverage 81.83% 71.53% -10.30%
===========================================
Files 32 51 +19
Lines 9992 12340 +2348
===========================================
+ Hits 8177 8828 +651
- Misses 1815 3512 +1697
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Benchmark for c0f9298Click to view benchmark
|
Licenser
force-pushed
the
alignment-improvements
branch
from
3aad36b to
5e56c5c
Compare
Benchmark for 97e1857Click to view benchmark
|
Licenser
force-pushed
the
alignment-improvements
branch
3 times, most recently
from
b17a98c to
54d1a9f
Compare
Benchmark for 9e4b729Click to view benchmark
|
Benchmark for bb4a1beClick to view benchmark
|
Benchmark for f0d7e5cClick to view benchmark
|
Licenser
force-pushed
the
alignment-improvements
branch
from
54d1a9f to
e650d48
Compare
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Licenser
force-pushed
the
alignment-improvements
branch
from
e650d48 to
55c8c7f
Compare
Benchmark for 2db3dddClick to view benchmark
|
|
@Licenser this seems worth it. |
|
While in theory I agree, the benchmarks kind of point to a different result while there are some that improve there are also some that quite noticeably degrade. The GitHub benchmarks are not a surefire way to determine exact numbers but if you look over all the runs the trend is showing a over all degradation not a improvement :( which is sad because it should be faster but CPUs and compilers are sneaky. |
There's only one big degradation which is |
|
If you look at all the benchmarks, both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve alignment to avoid unaligned memory reads