Added support for strongly typed ID values for each key structure #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a file with support for strongly typed IDs for the Book, Chapter, and Content structs.
Each ID struct contains a simple primitive, increasing in size so that the Chapter ID can be half its own ID, and half its Book's ID. This limits the potential number of IDs, but not by enough for it to be a problem for this app. (The user can still have up to 255 books on the app with this system.
More importantly, each struct has an ID marker trait, implemented generically, and ChapterID and ContentID implement CompositeID, so that this functionality could be extended to a different implementation, such as larger primitives or use an array of primitives.