Refactoring MI into python#73
Open
asistradition wants to merge 6 commits intosimonsfoundation:masterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=========================================
+ Coverage 72.25% 74.6% +2.35%
=========================================
Files 20 22 +2
Lines 1600 1768 +168
=========================================
+ Hits 1156 1319 +163
- Misses 444 449 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm breaking this down into smaller, more manageable chunks; this is the refactor of the mutual information calculations into pure python, using KVS to multiprocess. There's a new wrapper for the KVS client that gives a bit more functionality, and the MI module is a drop-in replacement for the mi_R module.
I've also included a few minor changes to the workflow that should substantially help the memory usage.