Skip to content

Conversation

@mhasself
Copy link
Member

Description

In cases where we check the ACU reply text to see if it indicates success, check against a short list of known "OK_responses".

This corrects a bug that makes the ACU Agent from #880 totally unusable at the site.

Motivation and Context

Most ACU commands return the success text "OK, Command executed." But some say "OK, Command send." Recent evolutions in soaculib and socs ended up using one of those latter commands, which prevented the agent from believing it had commanded successfully.

How Has This Been Tested?

Tested moves and scans on the ACU simulator, after updating it to return the second OK response, like a real ACU.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Changing how axes modes are set results in slightly different ok
message...
@mhasself mhasself requested a review from BrianJKoopman May 21, 2025 14:13
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updating the simulator with the new return string sounds good too.

@BrianJKoopman BrianJKoopman merged commit 3f8b068 into main May 21, 2025
4 checks passed
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-bug-fix branch May 21, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants