Skip to content

Conversation

@bbixler500
Copy link
Contributor

@bbixler500 bbixler500 commented Dec 17, 2025

This PR adds functionality to the hwp-supervisor agent to shut off bias power to the driver board during a triggered shutdown

Description

Currently, when a HWP shutdown is triggered the only actions taken is to lock out user controls and shut off the drive power. These actions alone are not enough to fully stop the HWP as the driver board bias power needs to be disabled as well (we should be doing this anyways because the electronics shouldn't be biased if there is expected to be large swings in the cryostat temperature). This PR adds to the hwp-supervisor's monitor process additional logic which shuts off the bias power once a shutdown is triggered.

Motivation and Context

See above

How Has This Been Tested?

This was tested successfully on satp2 by simulating a communication failure to initiate the shutdown

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman self-requested a review December 19, 2025 20:54
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though I have one suggestion on the implementation that should avoid cancel_shutdown being called when it doesn't really apply.

@BrianJKoopman BrianJKoopman self-requested a review December 19, 2025 21:40
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for answering those questions. Looks good to me!

@BrianJKoopman BrianJKoopman merged commit 51a4902 into main Dec 19, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the hwp-supervisor-shutdown branch December 19, 2025 21:42
@BrianJKoopman BrianJKoopman changed the title Hwp supervisor shutdown hwp-supervisor: Add missing shutdown procedure Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants