Skip to content

Conversation

@mhasself
Copy link
Member

Description

Make end_stop=True the default, for go_to and set_boresight tasks.

Technically this is an interface change, in that default behavior is affected, and default behavior is actively used in our running schedules. But it was agreed on DAQ call that this will be seen, by any who notices, as an improvement.

Motivation and Context

After each move, it is sensible to put on the brakes. We rarely care about servoing actively on any fixed position, because we only observe while scanning. This change does not affect behavior when scanning -- elevation axis will remain in Preset mode in that case (which may or may not be what is wanted; cf #964).

How Has This Been Tested?

Tested on simulator, but this is quite a minor change in any case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrianJKoopman BrianJKoopman merged commit 6f1239e into main Dec 19, 2025
4 checks passed
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-more-stopping branch December 19, 2025 20:31
@BrianJKoopman BrianJKoopman changed the title ACU: end_stop=True is now the default ACU: Make end_stop=True the default Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants