Skip to content

Conversation

@dpdutcher
Copy link
Contributor

New sodetlib version fixes bugs that were causing bias step analysis to fail on bad data.

Description

Dynamic tmin calculation was causing IndexErrors and ValueErrors if the data were bad, e.g. noisy or a flat line.
More checks have been implemented to catch these bad data and skip them.

Motivation and Context

Occasional crashes of bias_step analysis on SATp2, where sodetlib v0.6.0 was installed.

How Has This Been Tested?

1000+ bias step files have been re-analyzed by both Daniel and Kyohei with the fixed code, with no further crashes occurring.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

New sodetlib version fixes bugs that were causing bias step analysis to fail on bad data.
Changes have been tested by both Kyohei and Daniel on 1000+ bias step files, with no crashes occurring.
@dpdutcher dpdutcher requested review from a team, BrianJKoopman and ykyohei December 22, 2025 16:18
@davidvng davidvng merged commit 41bb3b4 into main Dec 22, 2025
5 checks passed
@davidvng davidvng deleted the sodetlib_v061 branch December 22, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants