Skip to content

Add fast brake option for hwp.py #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
17-sugiyama wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add fast brake option for hwp.py #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/sorunlib/hwp.py
View file
Open in desktop
Copy link
Member

@BrianJKoopman BrianJKoopman Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have noticed the failing tests in the checks. Two tests in test_hwp.py are failing. These should be modified to handle cases for the new fast argument.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def set_freq(freq):
check_response(hwp, resp)


def stop(active=True, brake_voltage=None):
def stop(active=True, brake_voltage=None, fast=False):
Copy link
Member

@BrianJKoopman BrianJKoopman Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new fast argument to the docstring.

"""Stop the HWP.

Args:
Expand All @@ -35,9 +35,9 @@ def stop(active=True, brake_voltage=None):

if active:
if brake_voltage is None:
resp = hwp.brake()
resp = hwp.brake(fast=fast)
else:
resp = hwp.brake(brake_voltage=brake_voltage)
resp = hwp.brake(brake_voltage=brake_voltage, fast=fast)
check_response(hwp, resp)
else:
resp = hwp.pmx_off()
Expand Down
Loading