Dev #17
Dev #17
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 30
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| <th | ||
| className={cn( | ||
| 'border px-4 py-2 text-left font-bold [&[align=center]]:text-center [&[align=right]]:text-right', | ||
| 'border px-4 py-2 text-left font-bold [[align=center]]:text-center [[align=right]]:text-right', |
There was a problem hiding this comment.
Invalid Tailwind CSS attribute selector syntax
The change from [&[align=center]] to [[align=center]] uses invalid Tailwind CSS syntax. The & character is required in arbitrary variants to reference the current element. Without it, [[align=center]] is not a valid Tailwind selector and the table cell alignment styling (centering cells with align attribute) will not work. This affects both th and td elements in MDX content.
Additional Locations (1)
| </div> | ||
| <DropdownMenu modal={false}> | ||
| <DropdownMenuTrigger asChild> | ||
| <DropdownMenuTrigger> |
There was a problem hiding this comment.
DropdownMenuTrigger without asChild creates nested buttons
Removing asChild from DropdownMenuTrigger without converting to the render prop pattern causes the component to render its default trigger element with the Button as a nested child. This creates invalid HTML with a button inside a button, which violates accessibility standards and causes unexpected behavior. The correct migration is to use the render prop like: <DropdownMenuTrigger render={<Button>...</Button>} />.
Additional Locations (2)
| </DropdownMenuTrigger> | ||
| <DropdownMenuContent align="end"> | ||
| <DropdownMenuItem | ||
| asChild |
There was a problem hiding this comment.
DropdownMenuItem without asChild breaks Link composition
Removing asChild from DropdownMenuItem with a Link child means the Link is no longer composed as the menu item element. Instead, the menu item renders its default element with the Link as a nested child. This breaks the intended navigation behavior and menu item styling. The correct pattern is to use render prop or keep asChild.
| > | ||
| <SelectTrigger className="[&>span]:truncate w-full"> | ||
| <SelectValue placeholder="---" /> | ||
| <SelectValue data-placeholder="---" /> |
There was a problem hiding this comment.
SelectValue uses data attribute instead of placeholder prop
The change from placeholder="---" to data-placeholder="---" on SelectValue incorrectly sets a data attribute instead of the placeholder prop. In Base UI's Select.Value component, the placeholder prop determines what text to display when no value is selected. Using data-placeholder just sets an HTML data attribute and the country dropdown will show nothing when empty instead of displaying "---".
| {methods.formState.isSubmitting && <Spinner />} | ||
| {methods.formState.isSubmitting | ||
| ? 'Sending instructions...' | ||
| : 'Send instructions'} |
There was a problem hiding this comment.
Submit button with redundant onClick causes double submission
The PR added onClick={methods.handleSubmit(onSubmit)} to a button that has type="submit" inside a form with onSubmit={methods.handleSubmit(onSubmit)}. When clicked, the onClick handler fires first, then the form's native submit event also triggers onSubmit. This causes handleSubmit(onSubmit) to be called twice per click, potentially sending duplicate password reset requests. The onClick should be removed since the form's onSubmit already handles submission.
Note
Modernizes UI and improves UX, while expanding CI coverage and bundle analysis.
UnderlinedTabswithTabs, updateDropdownMenuTriggerandCollapsibleTriggerusage, and standardize dialog/alert dialog open handling viaonOpenChange(+ close animation callbacks)loadingprop; add explicitSpinnerand action-specific submitting text across auth, documents, settings, billing, developers, and members modals/forms.rootcontainer in both dashboard and marketingroutes.marketing.Contact; marketing contact page imports the correctContactsection; MDX/table alignment classes adjusted; mobile menu no longer usesPortaldev; add Next.js bundle analysis for dashboard/marketing with artifacts; quality job unchanged functionallyWritten by Cursor Bugbot for commit 1a3eebd. This will update automatically on new commits. Configure here.