feat: Add ResourceLink content type (MCP 2025-11-25)#89
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55a03ff79e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lib/mcp_client/resource_link.rb
Outdated
| new( | ||
| uri: data['uri'], | ||
| name: data['name'], | ||
| description: data['description'], | ||
| mime_type: data['mimeType'], | ||
| annotations: data['annotations'] |
There was a problem hiding this comment.
ResourceLink.from_json only maps uri, name, description, mimeType, and annotations, so any title or size metadata present in a resource_link item is dropped during parsing and cannot be recovered from the resulting object. This causes user-visible data loss whenever servers include richer resource metadata (for example, display titles or byte size) in tool results.
Useful? React with 👍 / 👎.
simonx1
force-pushed
the
feature/resource-link
branch
from
b49d487 to
153b4e9
Compare
simonx1
force-pushed
the
feature/resource-link
branch
3 times, most recently
from
f1c5eac to
0a57807
Compare
simonx1
force-pushed
the
feature/resource-link
branch
from
0a57807 to
17ad376
Compare
simonx1
force-pushed
the
feature/resource-link
branch
from
17ad376 to
8077400
Compare
1 participant
Adds ResourceLink content type allowing tool results to reference server resources.