Skip to content

feat(Dr. Rai Reports): BP Fudging Action-Plan Component #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
igbanam wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Draft

feat(Dr. Rai Reports): BP Fudging Action-Plan Component #5735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adb6587
only validate the staetment where necessary
igbanam Dec 3, 2025
1472367
change bp fudging to boolean
igbanam Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/models/dr_rai/action_plan.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class DrRai::ActionPlan < ApplicationRecord
belongs_to :dr_rai_target, class_name: "DrRai::Target"
belongs_to :region

validates :statement, presence: true
validates :statement, presence: true, if: :target_uses_statement?

def indicator
dr_rai_indicator
Expand Down Expand Up @@ -44,4 +44,8 @@ def unprocessible?
denominator.negative? ||
numerator.nil?
end

def target_uses_statement?
DrRai::Target::NEEDS_STATEMENT.include?(indicator.type)
end
end
2 changes: 1 addition & 1 deletion app/models/dr_rai/bp_fudging_indicator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def display_name
end

def target_type_frontend
"percent"
"boolean"
end

def numerator_key all: nil
Expand Down
2 changes: 2 additions & 0 deletions app/models/dr_rai/target.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ class DrRai::Target < ApplicationRecord
"boolean" => "DrRai::BooleanTarget"
}

NEEDS_STATEMENT = %w[ percent numeric ].map { |t| TYPES[t] }.freeze

belongs_to :indicator, class_name: "DrRai::Indicator", foreign_key: "dr_rai_indicators_id"

validates :period, presence: true, format: {with: /\AQ\d-\d{4}\Z/}
Expand Down