Open
Conversation
Conflicts: lib/ohm/contrib.rb
Fix code example on README.
From Ohm 2, if an attribute is set to false, it's not saved. Related commit: soveran/ohm@717080f.
Fix Ohm::SoftDelete#restore. Remove key instead of set it to nil.
Add CHANGELOG.md file.
Remove Ohm::Datatypes#bool method.
Cast `deleted` attribute in Ohm::SoftDelete.
Add iconv to the gem manifest for Ruby versions >1.9.
No changes, just a matching release for ohm 2.0.0.rc2
Release 2.0.0.rc2
Release v2
- Rename Ohm::Locking#mutex to Ohm::Locking#spinlock
- Yes I admit the naming has some coincidence with the HN
thread involving linus here:
http://yarchive.net/comp/linux/semaphores.html
- More importantly, the rename has something to do with the
fact that `Ohm::Model.mutex` now exists, so trying to
extend `Ohm::Locking` into a model will result in a
conflict.
- Fix the bug
- So apparently, no one cares about Ohm::Locking anymore,
and I sort of fell off the grid so I never bothered to look.
- The bug involves not checking the value of SETNX explicitly
as 1 / 0, but just doing the truthy check (compliant with the
redis-rb protocol)
- Dunno why this is using HSET instead of SET as we're dealing
with a direct key here.
- Don't return self, as I don't remember why we even did that
in the past. It's surprising and more often is not the
behavior we're looking for.
- Rename Ohm::Locking#mutex to Ohm::Locking#spinlock
- Yes I admit the naming has some coincidence with the HN
thread involving linus here:
http://yarchive.net/comp/linux/semaphores.html
- More importantly, the rename has something to do with the
fact that `Ohm::Model.mutex` now exists, so trying to
extend `Ohm::Locking` into a model will result in a
conflict.
- Fix the bug
- So apparently, no one cares about Ohm::Locking anymore,
and I sort of fell off the grid so I never bothered to look.
- The bug involves not checking the value of SETNX explicitly
as 1 / 0, but just doing the truthy check (compliant with the
redis-rb protocol)
- Dunno why this is using HSET instead of SET as we're dealing
with a direct key here.
- Don't return self, as I don't remember why we even did that
in the past. It's surprising and more often is not the
behavior we're looking for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.