hacky update to allow array of selected options#3
Open
tansaku wants to merge 1 commit intosinefunc:masterfrom
Open
hacky update to allow array of selected options#3tansaku wants to merge 1 commit intosinefunc:masterfrom
tansaku wants to merge 1 commit intosinefunc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to get the test suite running yet, and this code is rather hacky - a better approach would probably to drop anything that isn't an array in an array.
I'll submit better versions if I have time, but wanted to submit what I had done and ask about how to run the test suite - here are the errors I am currently getting trying to run the test suite: