Moves UserAgent into Sinatra::UserAgentHelper namespace to fix collisions with other libraries#5
Open
anglinb wants to merge 1 commit intosinefunc:masterfrom
Open
Moves UserAgent into Sinatra::UserAgentHelper namespace to fix collisions with other libraries#5anglinb wants to merge 1 commit intosinefunc:masterfrom
anglinb wants to merge 1 commit intosinefunc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
UserAgentclass in thelib/sinatra/support/useragenthelpers.rbfile was not included in theSinatra::UserAgentHelpersnamespace which caused collisions in other libraries. Most recently, the lack of namespace cause issues withtwitter/secureheaders: Issue 335I simply moved the
UserAgentclass into the namespace. I ran the tests and they passed. TheUserAgentclass is actually only ever used in thelib/sinatra/support/useragenthelpers.rbfile so this should be a non-breaking change for most usages of this library.