Skip to content

Comments

Add java ref implementation#40

Open
erasmospunk wants to merge 1 commit intosipa:masterfrom
Coinomi:java-ref
Open

Add java ref implementation#40
erasmospunk wants to merge 1 commit intosipa:masterfrom
Coinomi:java-ref

Conversation

@erasmospunk
Copy link

@erasmospunk erasmospunk commented Jan 10, 2018

No description provided.

@sneurlax sneurlax mentioned this pull request Jan 14, 2018
Closed
@sneurlax
Copy link

sneurlax commented Jan 14, 2018 •
edited
Loading

Duplicate of #19 ?

@erasmospunk
Copy link
Author

erasmospunk commented Jan 17, 2018 •
edited
Loading

@sneurlax #19 had no updates from July. This tries to be as close to the C++ code as possible and uses byte arrays for higher efficiency. Also it it uses logical right shifts (>>>) and is careful with java byte to int sign extensions.

@erasmospunk
Copy link
Author

erasmospunk commented Jan 31, 2018

@sipa could you provide some feedback if anything is needed to merge this?

@schildbach
Copy link

schildbach commented Feb 15, 2018

I'm now in the process of integrating this code into bitcoinj.

@sneurlax sneurlax mentioned this pull request Feb 17, 2018
Closed
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 18, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
7fd0bef 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 18, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
ca4da5c 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 21, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
4ca17ba 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 21, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
e0c7af6 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 22, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
3e02dc3 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 23, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
8cd93a3 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 23, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
8bc4d0b 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 23, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
bbf4302 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 26, 2018
WIP Add SegwitAddress as a subclass of AbstractAddress (parent of Add…
de4b8ea 
…ress too).

Note the class names a subject to change, e.g.
AbstractAddress > Address
Address > LegacyAddress

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 27, 2018
Implement native segwit addresses in new SegwitAddress class.
63e94c8 
This commit establishes a base class for legacy and segwit addresses.

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 27, 2018
Implement native segwit addresses in new SegwitAddress class.
cfa636a 
This commit establishes a base class for legacy and segwit addresses.

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 27, 2018
Implement native segwit addresses in new SegwitAddress class.
68f6548 
This commit establishes a base class for legacy and segwit addresses.

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to schildbach/bitcoinj that referenced this pull request Feb 28, 2018
Implement native segwit addresses in new SegwitAddress class.
ea02021 
This commit establishes a base class for legacy and segwit addresses.

Uses Bech32 code from sipa/bech32#40.
schildbach pushed a commit to bitcoinj/bitcoinj that referenced this pull request Feb 28, 2018
Implement native segwit addresses in new SegwitAddress class.
6593d74 
This commit establishes a base class for legacy and segwit addresses.

Uses Bech32 code from sipa/bech32#40.
@erasmospunk
Copy link
Author

erasmospunk commented Oct 29, 2018

Hey @sipa, care to check this PR for merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phungice1234-prog phungice1234-prog phungice1234-prog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erasmospunk @sneurlax @schildbach @phungice1234-prog