ref/c: segwit_decode_addr_details: capture details and return#57
Open
switck wants to merge 2 commits intosipa:masterfrom
Open
ref/c: segwit_decode_addr_details: capture details and return#57switck wants to merge 2 commits intosipa:masterfrom
switck wants to merge 2 commits intosipa:masterfrom
Conversation
sipa
reviewed
Feb 3, 2021
ref/c/segwit_addr.c
Outdated
| if(hrp_out) { | ||
| strncpy(hrp_out, hrp_actual, 20); | ||
| } | ||
| if(enc_out) *enc_out = enc; |
Owner
There was a problem hiding this comment.
I don't like this. I cannot imagine a case where a caller is interested in valid or not, without caring if it's bech32 or bech32m. Validity is defined w.r.t. a specific standard.
Author
There was a problem hiding this comment.
I can make the enc_out argument required
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kept same API, but added a less-opinionated interface, that will allow caller to detect bech32m/not, incorrect HRP and report details to users