Open
Conversation
Contributor
meshcollider
left a comment
meshcollider
left a comment
There was a problem hiding this comment.
Looks good, haven't checked the tests.
| then guard (length witprog == 20 || length witprog == 32) >> return 1 | ||
| else guard (length witprog >= 2 && length witprog <= 40) >> return bech32mConst | ||
| where | ||
| bech32mConst = 0x2bc830a3 |
Contributor
There was a problem hiding this comment.
Might be nice to define a global sum type for the two encoding types and have a mapping function from encoding to checksum constant. Then it can be exported to the tests.
Contributor
Author
|
I've added two commits which I will squash afterwards. |
Contributor
|
utACK 7736efe |
roconnor-blockstream
force-pushed
the
2021110_haskell_bech32m
branch
from
7736efe to
7d25521
Compare
Contributor
Author
|
squashed some commits. |
Contributor
|
re-ACK 7d25521, no changes in squash |
sipa
reviewed
Jan 25, 2022
roconnor-blockstream
force-pushed
the
2021110_haskell_bech32m
branch
from
7d25521 to
c31bf76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also includes a slightly refactored version of PR #41.