Use connection pool for Redis#34
Merged
casperisfine merged 2 commits intosirupsen:masterfrom Mar 24, 2025
Merged
Conversation
Contributor
|
It was added in 4.7.0 though, so you probably need to bump the redis dependency. |
Collaborator
Author
|
Done! do you want me to include a version bump here as well? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Redis instance might not be the client itself, but a connection pool. This PR makes progressrus call
.withto obtain a connection from the pool.Thankfully,
Redis::Clientimplementswithto be backward compatible with the connection pool implementation. So we can safely ship this and it will be a no-op for those who don't use connection pooling.cc @byroot