-
Notifications
You must be signed in to change notification settings - Fork 12
chore: fix and align dependencies across different packages #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3a45999 to
5296c5e
Compare
β¦use newer angular dependencies
c5b3076 to
6817c4c
Compare
β¦re/fix-dependencies # Conflicts: # examples/react/package.json # package-lock.json
pennal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general. I think this is fine. What I am noticing though is that we havent yet decided on how we want to declare dependencies, whether we want to pinpoint them or we want to allow some freedom to the package manager.
| "react": "^19.2.1", | ||
| "react-dom": "^19.2.1", | ||
| "react-router": "^7.10.1" | ||
| "react": "^19.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you rolling these back? According to https://react.dev/blog/2025/12/11/denial-of-service-and-source-code-exposure-in-react-server-components we should be using >=19.1.3 or 19.2.2
| "@types/react-dom": "^19", | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "typescript": "5.8.3", | ||
| "@vitejs/plugin-react": "^4.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In both the react and vue packages you are not pinpointing versions, which you are doing in angular. Is there a reason for this?
f8be016 to
100dd72
Compare
π Linked issue
β Type of change
π Description
π Checklist
mainbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: