Skip to content

Conversation

@colinscz
Copy link
Collaborator

@colinscz colinscz commented Dec 15, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Addresses latest react vulnerabilities
  • Aligns used Typescript version across workspace
  • Remove unused packages in Nuxt demo app dev dependencies

πŸ“ Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@colinscz colinscz requested review from ibirrer and pennal December 15, 2025 09:53
@colinscz
Copy link
Collaborator Author

@ibirrer @pennal I updated the packages, but seems now the angular output has an issue with the value accessor and some typings. React and vue output and libs seems to build fine. I found it weird that the date-fns is only listed as a peer but is necessary for some of the web components. Not sure about this.

@colinscz colinscz added this to the v5.3.0 milestone Dec 15, 2025
@pennal
Copy link
Collaborator

pennal commented Dec 15, 2025

@ibirrer @pennal I updated the packages, but seems now the angular output has an issue with the value accessor and some typings. React and vue output and libs seems to build fine. I found it weird that the date-fns is only listed as a peer but is necessary for some of the web components. Not sure about this.

This is exactly the issue I have been experiencing. The moment you change one of the packages (not sure which one tbh) the build breaks and there is an issue with the typings. Could we just avoid upgrading the other packages, and try to force the react update? In theory these new versions are all compatible with the old ones so should be possible to massage the package-lock to work with these

EDIT: The more I look at this, the more I believe we should just update the CVE-related libs and leave the rest for another PR.

@colinscz colinscz marked this pull request as ready for review December 15, 2025 12:46
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/six-group/six-webcomponents/@six-group/ui-library@463
npm i https://pkg.pr.new/six-group/six-webcomponents/@six-group/ui-library-angular@463
npm i https://pkg.pr.new/six-group/six-webcomponents/@six-group/ui-library-react@463
npm i https://pkg.pr.new/six-group/six-webcomponents/@six-group/ui-library-vue@463

commit: c946f3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants