Open
Conversation
strattonbrazil
approved these changes
Dec 1, 2021
Collaborator
strattonbrazil
left a comment
strattonbrazil
left a comment
There was a problem hiding this comment.
Looks good to me. A few suggestions that might clean things up a bit.
| // A deep clone also copies children. | ||
| if (isDeepCopy) { | ||
| let appendChild = copy.getMethod("appendchild"); | ||
| let getChildren = toBeCloned.getMethod("getchildren"); |
Collaborator
There was a problem hiding this comment.
This code would be a little cleaner if we exposed getChildren in typescript. I wonder if that's worth it. Then the callable would just wrap that response in an RoArray.
underwoo16
approved these changes
Dec 1, 2021
Contributor
underwoo16
left a comment
underwoo16
left a comment
There was a problem hiding this comment.
I agree with @strattonbrazil suggestions, otherwise this looks great 👍🏼
alimnios72
reviewed
Dec 2, 2021
alimnios72
approved these changes
Dec 3, 2021
Collaborator
alimnios72
left a comment
alimnios72
left a comment
There was a problem hiding this comment.
Thanks for the changes
This reverts commit 7ba2022.
strattonbrazil
approved these changes
Jan 6, 2022
Contributor
|
@anyatokar this project is stalled and the Roku Community has forked it (see @sjbarag suggestion on #681) do you mind re-pushing your PR on https://github.com/rokucommunity/brs ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
.clone(isDeepCopy as Boolean)for ifSGNodeDict interface. Both shallow and deep clones copy Fields but only the deep clone copies Children.Added associated unit and e2e tests.