Skip to content

Remove multi-lines queries. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfg956 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove multi-lines queries. #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions model/fileinfo/rows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,7 @@ func collect(db *sql.DB) Rows {
var t Rows
start := time.Now()

sql := `
SELECT FILE_NAME,
SUM_TIMER_WAIT,
SUM_TIMER_READ,
SUM_TIMER_WRITE,
SUM_NUMBER_OF_BYTES_READ,
SUM_NUMBER_OF_BYTES_WRITE,
SUM_TIMER_MISC,
COUNT_STAR,
COUNT_READ,
COUNT_WRITE,
COUNT_MISC
FROM file_summary_by_instance
WHERE SUM_TIMER_WAIT > 0
`
sql := `SELECT FILE_NAME, SUM_TIMER_WAIT, SUM_TIMER_READ, SUM_TIMER_WRITE, SUM_NUMBER_OF_BYTES_READ, SUM_NUMBER_OF_BYTES_WRITE, SUM_TIMER_MISC, COUNT_STAR, COUNT_READ, COUNT_WRITE, COUNT_MISC FROM file_summary_by_instance WHERE SUM_TIMER_WAIT > 0`

rows, err := db.Query(sql)
if err != nil {
Expand Down
11 changes: 1 addition & 10 deletions model/memoryusage/row.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,7 @@ func collect(db *sql.DB) []Row {
var t []Row
var skip bool

sql := `-- memoryusage
SELECT EVENT_NAME AS eventName,
CURRENT_COUNT_USED AS currentCountUsed,
HIGH_COUNT_USED AS highCountUsed,
CURRENT_NUMBER_OF_BYTES_USED AS currentBytesUsed,
HIGH_NUMBER_OF_BYTES_USED AS highBytesUsed,
COUNT_ALLOC + COUNT_FREE AS totalMemoryOps,
SUM_NUMBER_OF_BYTES_ALLOC + SUM_NUMBER_OF_BYTES_FREE AS totalBytesManaged
FROM memory_summary_global_by_event_name
WHERE HIGH_COUNT_USED > 0`
sql := `SELECT EVENT_NAME, CURRENT_COUNT_USED, HIGH_COUNT_USED, CURRENT_NUMBER_OF_BYTES_USED, HIGH_NUMBER_OF_BYTES_USED, COUNT_ALLOC + COUNT_FREE, SUM_NUMBER_OF_BYTES_ALLOC + SUM_NUMBER_OF_BYTES_FREE FROM memory_summary_global_by_event_name WHERE HIGH_COUNT_USED > 0`

log.Println("Querying db:", sql)
rows, err := db.Query(sql)
Expand Down
19 changes: 1 addition & 18 deletions model/tablelocks/rows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,7 @@ func totals(rows []Row) Row {
// - filter out empty values
// - change FILE_NAME into a more descriptive value.
func collect(db *sql.DB, filter *filter.DatabaseFilter) []Row {
sql := `
SELECT OBJECT_SCHEMA,
OBJECT_NAME,
SUM_TIMER_WAIT,
SUM_TIMER_READ,
SUM_TIMER_WRITE,
SUM_TIMER_READ_WITH_SHARED_LOCKS,
SUM_TIMER_READ_HIGH_PRIORITY,
SUM_TIMER_READ_NO_INSERT,
SUM_TIMER_READ_NORMAL,
SUM_TIMER_READ_EXTERNAL,
SUM_TIMER_WRITE_ALLOW_WRITE,
SUM_TIMER_WRITE_CONCURRENT_INSERT,
SUM_TIMER_WRITE_LOW_PRIORITY,
SUM_TIMER_WRITE_NORMAL,
SUM_TIMER_WRITE_EXTERNAL
FROM table_lock_waits_summary_by_table
WHERE COUNT_STAR > 0`
sql := `SELECT OBJECT_SCHEMA, OBJECT_NAME, SUM_TIMER_WAIT, SUM_TIMER_READ, SUM_TIMER_WRITE, SUM_TIMER_READ_WITH_SHARED_LOCKS, SUM_TIMER_READ_HIGH_PRIORITY, SUM_TIMER_READ_NO_INSERT, SUM_TIMER_READ_NORMAL, SUM_TIMER_READ_EXTERNAL, SUM_TIMER_WRITE_ALLOW_WRITE, SUM_TIMER_WRITE_CONCURRENT_INSERT, SUM_TIMER_WRITE_LOW_PRIORITY, SUM_TIMER_WRITE_NORMAL, SUM_TIMER_WRITE_EXTERNAL FROM table_lock_waits_summary_by_table WHERE COUNT_STAR > 0`

args := []interface{}{}

Expand Down