SkipWebScrollDelegate callbacks#37
Conversation
…tches on android, i.e. timing of DRAG -> DECEL mode is off)
…> COAST > REST from the lab)
scripts/pre-pr-check.sh
Outdated
There was a problem hiding this comment.
I'd rather keep scripts like this out. You should be able to pre-build the package for iOS just by running skip export --debug, which will validate that the project builds for iOS as well as Android.
There was a problem hiding this comment.
Ah yes, this was accidentally added to the repo. I will remove it & resubmit.
A related question: the purpose of the script is to mirror the CI Action so I can catch possible issues before submitting a PR by running XCTests on a simulator/device (instead of macOS). Does skip export --debug cover this? If so I will throw away the script entirely if can rely on skip export --debug exclusively
There was a problem hiding this comment.
It doesn't run the tests, it just builds against the iOS destination. So you might want to keep the script around somewhere for your own purposes (or else just manually run the test cases from Xcode).
Or just wait and see if CI fails. There's no harm in iterating on a PR after a CI failure 😸
|
It took me a few tries, but CI is passing now |
|
Great contribution, thanks! |
Implemented the
UIScrollViewDelegate-equivalent forskip-web. SeeSkipWebScrollDelegatefor the shape of the delegate callsSkip Pull Request Checklist:
swift testCodex wrote the code under supervision. Manually tested from a native sandbox app
Attached: video capture of the test on android
scroll-debug-720p.mp4