Skip to content

SkipWebScrollDelegate callbacks#37

Merged
marcprux merged 7 commits intoskiptools:mainfrom
tifroz:codex/scrollview-delegate-callbacks
Mar 7, 2026
Merged

SkipWebScrollDelegate callbacks#37
marcprux merged 7 commits intoskiptools:mainfrom
tifroz:codex/scrollview-delegate-callbacks

Conversation

@tifroz
Copy link
Contributor

@tifroz tifroz commented Mar 5, 2026

Implemented the UIScrollViewDelegate-equivalent for skip-web. See SkipWebScrollDelegate for the shape of the delegate calls

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.
    Codex wrote the code under supervision. Manually tested from a native sandbox app

Attached: video capture of the test on android

scroll-debug-720p.mp4

@cla-bot cla-bot bot added the cla-signed label Mar 5, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep scripts like this out. You should be able to pre-build the package for iOS just by running skip export --debug, which will validate that the project builds for iOS as well as Android.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this was accidentally added to the repo. I will remove it & resubmit.

A related question: the purpose of the script is to mirror the CI Action so I can catch possible issues before submitting a PR by running XCTests on a simulator/device (instead of macOS). Does skip export --debug cover this? If so I will throw away the script entirely if can rely on skip export --debug exclusively

Copy link
Member

@marcprux marcprux Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't run the tests, it just builds against the iOS destination. So you might want to keep the script around somewhere for your own purposes (or else just manually run the test cases from Xcode).

Or just wait and see if CI fails. There's no harm in iterating on a PR after a CI failure 😸

@tifroz
Copy link
Contributor Author

tifroz commented Mar 6, 2026

It took me a few tries, but CI is passing now

@marcprux marcprux changed the title Codex/scrollview delegate callbacks SkipWebScrollDelegate callbacks Mar 7, 2026
@marcprux
Copy link
Member

marcprux commented Mar 7, 2026

Great contribution, thanks!

@marcprux marcprux merged commit c85ec0a into skiptools:main Mar 7, 2026
2 checks passed
@tifroz tifroz deleted the codex/scrollview-delegate-callbacks branch March 8, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants