Skip to content

Remove import of ObjectiveC.NSObject for native builds#3

Merged
marcprux merged 1 commit intoskiptools:mainfrom
tifroz:codex/fix-android-build
Mar 3, 2026
Merged

Remove import of ObjectiveC.NSObject for native builds#3
marcprux merged 1 commit intoskiptools:mainfrom
tifroz:codex/fix-android-build

Conversation

@tifroz
Copy link
Contributor

@tifroz tifroz commented Mar 2, 2026

Error: /skip-xml/Sources/SkipXML/SkipXML.swift:14:14: error: no such module 'ObjectiveC'

Not sure why skip android build would try to compile the native path (inside #if !SKIP) in a transpiled module? Either way, it doesn't seem like import ObjectiveC .NSObject is actually needed on any compile path so might as well remove it

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

(Also ran skip android build successfully)


  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

…t:14:14: error: no such module 'ObjectiveC'`)
@cla-bot cla-bot bot added the cla-signed label Mar 2, 2026
@tifroz
Copy link
Contributor Author

tifroz commented Mar 3, 2026

It looks like the CI action failed because of a missing emulator in the environment Vs an issue with the change? I am not well-versed in gh actions...

"simulator name that is not present on the runner image being used"

@marcprux
Copy link
Member

marcprux commented Mar 3, 2026

"simulator name that is not present on the runner image being used"

This is a weird intermittent error that GH Actions sometimes raises (e.g., see actions/runner-images#13220), which usually goes away when the job is re-run (which I have requested). It has nothing to do with the change you made.

@marcprux
Copy link
Member

marcprux commented Mar 3, 2026

This library predates Skip Fuse, and so had only been designed with transpiled Skip Lite in mind. That being said, there's no reason why it shouldn't also work natively with Skip Fuse, and I don't know why we ever needed to import ObjectiveC.NSObject (it came in at 8301c98).

@marcprux marcprux merged commit 0640e4d into skiptools:main Mar 3, 2026
2 of 4 checks passed
@marcprux marcprux changed the title Fix for skip android build Remove import of ObjectiveC.NSObject for native builds Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants