Some refactoring and unpacking hacks. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging is now done by collecting messages (strings) in a list. When it becomes necessary, these messages can be concatenated. On failure, functions no longer return an empty tuple (), but None. And miscellaneous changes to make everything a bit more Pythonic.
CraignRush
pushed a commit
to CraignRush/SerialFIB
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sven!
Nice work with SerialFIB. I've made a couple changes inside
AquilosDriver.py, including one which unpacks adictinto aStagePositionobject. I find it quite a neat trick, and thought you might like it.Best,
James