Skip to content

eliminate the result accumulator setup outside the reduce #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baob wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −5
Open

eliminate the result accumulator setup outside the reduce #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions roman_numerals/roman_numerals_medium.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,11 @@ def to_i(str)
end

def to_roman(number)
result = ''
ROMAN_NUMERALS.keys.reduce(number) {|to_be_converted, base_10_value|
ROMAN_NUMERALS.keys.reduce(['', number]) {|(result, to_be_converted), base_10_value|
num_chars_needed, remainder = to_be_converted.divmod(base_10_value)
result << ROMAN_NUMERALS[base_10_value] * num_chars_needed
remainder
}
result.to_subtractive_roman
[result, remainder]
}.first.to_subtractive_roman
end

def to_number(roman)
Expand Down
Empty file modified roman_numerals/roman_numerals_medium_test.rb
100644 → 100755
View file
Open in desktop
Empty file.