asynchronous APIs #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieudutour
requested changes
Jan 21, 2019
Member
mathieudutour
left a comment
mathieudutour
left a comment
There was a problem hiding this comment.
The error handling is so nice, well done!
Regarding the delegate.js file, I'd prefer to use cocoascript-class (see #12) which doesn't use eval and doesn't create a new class everytime it's called.
Same, I'd rather have a bit of duplicated code than having an abstraction that forces us to use eval (which is terrible for performance)
Author
|
Okay, you can pick up what you want during this PR, and feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding to #12