Server side changes for using saved fix coordinates with for the RTK base #10
Conversation
|
|
ntamas
left a comment
ntamas
left a comment
There was a problem hiding this comment.
Only a few minor changes, thanks a lot!
| self.position_ecef = position | ||
| self._antenna_position_timestamp = monotonic() | ||
|
|
||
| def set_from_ecef(self, position: ECEFCoordinate) -> None: |
There was a problem hiding this comment.
Please add documentation for this method.
| preset_id, desired_preset = None, None | ||
|
|
||
| # Always reset fixed position when switching RTK source | ||
| self._survey_settings.position = None |
There was a problem hiding this comment.
Can you please double check that if you have a fixed position preset in the server config file those coordinates will be loaded back properly after many preset changes?
|
somehow managed to fix the CLI conflict with my (now removed) |
| self.position_ecef = position | ||
| self._antenna_position_timestamp = monotonic() | ||
|
|
||
| def set_from_ecef(self, position: ECEFCoordinate) -> None: |
There was a problem hiding this comment.
Why do you have this function twice?
| preset_id, desired_preset = None, None | ||
|
|
||
| # Always reset fixed position when switching RTK source | ||
| self._survey_settings.position = None |
There was a problem hiding this comment.
do we need to check if a fixed position is configured for this preset here?
There was a problem hiding this comment.
this has already changed but wasnt commited at that time
| preset_id, desired_preset = None, None | ||
|
|
||
| # Reset fixed position when switching RTK source, but restore from config if available | ||
| self._survey_settings.position = self._config_fixed_position |
There was a problem hiding this comment.
You need to explicitly update self._config_fixed_position = None somewhere at the beginning of configuration parsing for cases when there is no fixed position stored and parsed properly from configuration
4 participants
No description provided.