Avoid copyPixels for full-sheet frames.#23
Open
Leander1P wants to merge 1 commit intoskylarkstudio:masterfrom
Open
Avoid copyPixels for full-sheet frames.#23Leander1P wants to merge 1 commit intoskylarkstudio:masterfrom
Leander1P wants to merge 1 commit intoskylarkstudio:masterfrom
Conversation
Our toolchain is a little naive and occasionally produces a Spritesheet with a single full-image frame. This avoids taking copyPixels overhead when this happens, instead referencing the existing sourceImage directly. This does require that sourceImageAlpha is null (otherwise the copyChannel would break this).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our toolchain is a little naive and occasionally produces a Spritesheet
with a single full-image frame.
This avoids taking copyPixels overhead when this happens, instead
referencing the existing sourceImage directly. This does require that
sourceImageAlpha is null (otherwise the copyChannel would break this).
Posting this mostly as an RFC; I could see some possible arguments against it.