Discard sourceImage when all frames generated.#24
Open
Leander1P wants to merge 1 commit intoskylarkstudio:masterfrom
Open
Discard sourceImage when all frames generated.#24Leander1P wants to merge 1 commit intoskylarkstudio:masterfrom
Leander1P wants to merge 1 commit intoskylarkstudio:masterfrom
Conversation
After the final frame is pulled in by generateBitmap(i) call, it appears we can safely null both sourceImage and sourceImageAlpha. The usual uses of merge and updateImage and other methods seems to be supported; the one case this might break is a "merge with another spritesheet with the same sourceImage and sourceImageAlpha as ourselves", causing it to generate frames earlier than it would have otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the final frame is pulled in by generateBitmap(i) call, it appears
we can safely null both sourceImage and sourceImageAlpha.
The usual uses of merge and updateImage and other methods seems to be
supported; the one case this might break is a "merge with another
spritesheet with the same sourceImage and sourceImageAlpha as ourselves",
causing it to generate frames earlier than it would have otherwise.
Once again, I could see some arguments against this, so posting as an RFC. It's been fairly effective at memory reduction in mobile browsers for us.