Skip to content

refactor: remove logger from activity, manifest, datastore, auth, and app delete/uninstall #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwbrooks wants to merge 1 commit into
base: main
Choose a base branch
from
+201 −593

refactor: remove logger from activity, validate, datastore, auth list…

83f47e1
Select commit
Loading
Failed to load commit list.
Open

refactor: remove logger from activity, manifest, datastore, auth, and app delete/uninstall #364

refactor: remove logger from activity, validate, datastore, auth list…
83f47e1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 6, 2026 in 0s

64.96% (-0.11%) compared to c449532

View this Pull Request on Codecov

64.96% (-0.11%) compared to c449532

Details

Codecov Report

❌ Patch coverage is 71.29630% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.96%. Comparing base (c449532) to head (83f47e1).

Files with missing lines Patch % Lines
internal/pkg/apps/uninstall.go 0.00% 7 Missing ⚠️
cmd/manifest/validate.go 57.14% 5 Missing and 1 partial ⚠️
internal/pkg/apps/delete.go 50.00% 4 Missing ⚠️
internal/pkg/manifest/validate.go 57.14% 3 Missing ⚠️
cmd/platform/activity.go 0.00% 0 Missing and 1 partial ⚠️
internal/pkg/datastore/bulk_delete.go 66.66% 1 Missing ⚠️
internal/pkg/datastore/bulk_get.go 66.66% 1 Missing ⚠️
internal/pkg/datastore/bulk_put.go 66.66% 1 Missing ⚠️
internal/pkg/datastore/delete.go 66.66% 1 Missing ⚠️
internal/pkg/datastore/get.go 66.66% 1 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   65.06%   64.96%   -0.11%     
==========================================
  Files         215      215              
  Lines       18179    18024     -155     
==========================================
- Hits        11829    11710     -119     
+ Misses       5254     5222      -32     
+ Partials     1096     1092       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov