Removed support for .Net Framework 4.6 by Andi482 · Pull Request #25 · slorion/nlight

Andi482 · 2022-11-29T22:46:50Z

Removed support for .Net Framework 4.6
Upgraded test & benchmark projekt to .net 6.0
Upgraded NuGet packages. Updated CsvHelper benchmark code to the new CsvHelper version
(These changes fixed package downgrade warnings and publish issues with a newer .net 6.0 / EF. Core 7.0 application)

Upgraded test & benchmark projekt to .net 6.0 Upgraded NuGet packages. Updated CsvHelper benchmark code to the new CsvHelper version

slorion · 2022-11-30T10:37:40Z

src/NLight.Tests.Benchmarks/IO/Text/DelimitedRecordReaderBenchmarks.cs

-						var record = reader.Context.Record;
-						for (int i = 0; i < record.Length; i++)
-							s = record[i];
+						IDictionary<string,Object> record = (IDictionary<string, Object>)reader.GetRecord<dynamic>();


Isn't there a more elegant (and faster) way to read values from the record?

Sorry, I´m not used to the CsvHelper library. I just tried to make the code working. Should I downgrade the CsvHelper nuget package to the old version, so that the original code is working again?

Looking at CsvHelper Reader class source, I think new code should be (did not test it)

while (reader.Read()) { for (int i = 0; i < reader.ColumnCount; i++) s = reader[i]; }

Yes, it´s working with this code.

slorion · 2022-11-30T10:39:10Z

src/NLight/NLight.csproj

-    <PackageReleaseNotes>Added multi-targeting support for .NET 4.6</PackageReleaseNotes>
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>C:\projects\oss\nlight\src\NLight.snk</AssemblyOriginatorKeyFile>
+    <PackageReleaseNotes>Increased compatibility to newer .net versions. Removed support for .NET 4.6</PackageReleaseNotes>


Please state minimal supported version (.NET 6)

With netstandard2.0 and System.Reactive.Core.5.0.0 we can keep the library backwards compatible to Framework 4.7.2.

slorion · 2022-11-30T10:43:18Z

src/NLight/NLight.csproj

  <PropertyGroup>
-    <TargetFrameworks>netstandard2.0;net46</TargetFrameworks>
-    <Version>2.1.1</Version>
+    <TargetFrameworks>netstandard2.0</TargetFrameworks>


Would it make sense to target .NET 6 here as well?

I kept the settings to netstandard, so people who are still using classic .net framework are still able to use this library.

slorion · 2022-11-30T10:44:02Z

src/NLight/NLight.csproj

-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>C:\projects\oss\nlight\src\NLight.snk</AssemblyOriginatorKeyFile>
+    <PackageReleaseNotes>Increased compatibility to newer .net versions. Removed support for .NET 4.6</PackageReleaseNotes>
+    <!--<SignAssembly>true</SignAssembly>


Please uncomment. I will publish to Nuget once PR merged

slorion · 2022-11-30T10:45:14Z

Hello, thank you for this PR, very much appreciated and I'm glad that my library is still being used after all those years ;-)

…o modern-dotnet

slorion · 2022-12-01T08:39:34Z

Based on your comments in the code, I am not sure I understand what is the minimum change required to remove package downgrade warning when using .NET 6? Taking a step back, it would probably make sense to refresh the library by targeting .NET 6 since it merges netcoreapp and netstandard.

Andi482 · 2022-12-01T10:13:29Z

Based on your comments in the code, I am not sure I understand what is the minimum change required to remove package downgrade warning when using .NET 6? Taking a step back, it would probably make sense to refresh the library by targeting .NET 6 since it merges netcoreapp and netstandard.

I had the following downgrade warning with the old library during publish:

Detected package downgrade: System.IO.FileSystem from 4.3.0 to 4.0.1. Reference the package directly from the project to select a different version.
32> MyProject -> NLight 2.1.1 -> System.Reactive.Core 3.1.1 -> System.Reactive.Interfaces 3.1.1 -> NETStandard.Library 1.6.0 -> System.Net.Sockets 4.1.0 -> runtime.win.System.Net.Sockets 4.3.0 -> System.IO.FileSystem (>= 4.3.0)
32> MyProject -> NLight 2.1.1 -> System.Reactive.Core 3.1.1 -> System.Reactive.Interfaces 3.1.1 -> NETStandard.Library 1.6.0 -> System.IO.FileSystem (>= 4.0.1)

Upgrading the library to System.Reactive.Core 5.0.0 solved this problem. But 5.0.0 is not longer compatible with net4.6, so I removed this target framework. But it is compatible with netstandard 2.0 and can also be used in old .net 4.7.2. projekts (System.Reactive.Core is also compatible to 4.7.2, according to the information on the nuget page for this package)

I wanted to make sure, that the library keeps compatible to as many projects as possible, and people "stucked" to classic framework can still use this library.

I could also fix it by manually adding System.IO.FileSystem 4.3.0 to MyProject, but I think it is much easier, when it work´s out of the box.

slorion · 2022-12-01T10:40:43Z

src/NLight/NLight.csproj

    <PackageProjectUrl>https://github.com/slorion/nlight</PackageProjectUrl>
    <PackageTags>io,parser,csv,delimited,transaction,reactive,tree</PackageTags>
-    <PackageReleaseNotes>Added multi-targeting support for .NET 4.6</PackageReleaseNotes>
+    <PackageReleaseNotes>Increased compatibility to newer .net versions. Minimum supported .NET Version is 4.7.2 (.NET Standard 2.0)</PackageReleaseNotes>


Could you change to "Increased compatibility with newer .NET versions. Updated Reactive dependency to 5.0. NLight targets .NET Standard 2.0 (.NET Framework 4.6.1+, .NET Core 2.0+)."

See https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#net-5-and-net-standard for compatibility matrix.

slorion · 2022-12-01T10:43:26Z

Thanks, I get it now. I will just have a quick look how to update the benchmark code for CsvHelper to avoid using dynamic.

…void using dynamic.

slorion · 2022-12-07T05:14:52Z

Thank you for update, I will be able to have final look and merge next week.

Andi482 · 2023-05-23T15:06:45Z

Hi, do i need to do anything else? Or can the code be merged?

slorion · 2023-05-29T10:13:31Z

Sorry for delay, I had to prioritize work, but hopefully will get around this by end of June.

Removed support for .Net Framework 4.6

4269970

Upgraded test & benchmark projekt to .net 6.0 Upgraded NuGet packages. Updated CsvHelper benchmark code to the new CsvHelper version

slorion reviewed Nov 30, 2022

View reviewed changes

Andreas Pampuch and others added 3 commits November 30, 2022 15:15

Uncommented assembly signing, updated package release notes.

cdc20f7

Uncommented assembly signing, updated package release notes.

05dfa0f

Merge branch 'modern-dotnet' of https://github.com/Andi482/nlight int…

70e8f76

…o modern-dotnet

slorion reviewed Dec 1, 2022

View reviewed changes

Updated package description; Optimized CSV-Helper benchmark code to a…

7433418

…void using dynamic.

Conversation

Andi482 commented Nov 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slorion commented Nov 30, 2022

Uh oh!

slorion commented Dec 1, 2022

Uh oh!

Andi482 commented Dec 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slorion commented Dec 1, 2022

Uh oh!

slorion commented Dec 7, 2022

Uh oh!

Andi482 commented May 23, 2023

Uh oh!

slorion commented May 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants