Press start to play fix for ex #382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed missing press start to play sound and hello when demo starts from begining.
fixed missing press start to play sound and hello when demo starts from begining.
fixed missing press start to play sound and hello when demo starts from begining.
fixed missing press start to play sound and hello when demo starts from begining.
Collaborator
|
You seem to have tried to PR a nightly-based branch into master. Please retarget to nightly. |
Contributor
|
@fgsfdsfgs Target's changed to the proper target. Try another look now |
Collaborator
|
That diff nukes and replaces the entire file. Maybe different line endings? I wouldn't advise using Github's file upload feature for PRs. |
Contributor
|
The one who made this PR isn't very well versed with PRs in general so I may try to optimize this PR a bit later. Hopefully it'll help |
Contributor
|
PR #455 supersedes this PR |
This was referenced Feb 12, 2021
Collaborator
|
This still nukes and replaces the entire file, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the press start to play issue. Locate in level_select_menu.c