Remove job-level permissions from workflow_call-only workflows#294
Merged
Remove job-level permissions from workflow_call-only workflows#294
Conversation
Job-level permissions blocks in workflow_call-only workflows cannot escalate permissions beyond the caller's grant — they can only restrict. When a caller sets restrictive top-level permissions (e.g. contents: read), GitHub's static parse-time validation fails the entire workflow with startup_failure if any nested job declares permissions exceeding the caller's grant, even for jobs guarded by `if:` conditions. Remove permissions blocks from: - goCI.yml: top-level permissions and codeql job permissions - zizmor.yml: zizmor job permissions - codeql-analysis.yml: codeql-analyze job permissions - frizbee.yml: frizbee job permissions Add .github/zizmor.yml config to suppress the resulting excessive-permissions findings for goCI.yml, consistent with the convention used in other repos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hslatman
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissionsblocks from jobs inworkflow_call-only workflows (goCI.yml,zizmor.yml,codeql-analysis.yml,frizbee.yml)contents: read), GitHub's static parse-time validation fails the entire workflow withstartup_failureif any nested job declares permissions exceeding the caller's grant, even for jobs guarded byif:conditions.github/zizmor.ymlto suppress the resultingexcessive-permissionsfindings forgoCI.yml, consistent with other reposSee smallstep/certificates#2582 for the motivating failure.
Test plan
actionlintpasseszizmor --min-severity medium --min-confidence mediumpasses (0 findings)startup_failure🤖 Generated with Claude Code