add support for linux clang cross compiles#1403
Conversation
|
sorry for the giant diff, but it had to be done at some point |
|
Doesn't #465 do the same thing as this PR? |
|
Could you modify COMPILE.md to add some instructions on how to compile it with clang? |
|
@StevenSYS yes but it's really old. |
yeah i can this weekend. all the steps are in flake.nix if you wanna test it right now tho |
it works quite well actually, and has been merged into LegacyEvolved |
59dc208 to
7f6ed5f
Compare
# Conflicts: # Minecraft.Client/Common/UI/UIScene_ConnectingProgress.cpp
|
i modified COMPILE.md |
|
Someone should make a dedicated PR that just fixes the slashes in the include paths, which can be merged in advance, and then that will make PRs like this smaller and easier to review once rebased on top. |
be the change you want to see in the world |
|
@codeHusky thoughts on this? |
|
running a build to see if it works |
|
me when the checks fail cause format check action is very dumb ill also check if this works on my arch setup soon today, if it works there then i think it should be good for merging |
|
as far as i can tell, running clang-format changes most of the files (when it doesn't eat all of my ram trying to format the one 96 thousand line file). it also changes most files on the repo before my pr tho, so idk if you want me to commit the formatting |
we removed the clang format action check anyways |
Description
add support for compiling the exe from linux using clang
Changes
Previous Behavior
builds on linux with clang would fail in a number of ways
Root Cause
mostly due to weird capitalization issues and the use of backslashes in file paths
New Behavior
file paths now use forward slashes and proper capitalization, which shouldn't affect how it builds with msvc
Fix Implementation
i used a lot of sed find and replace. i also added a nix flake for building on nixos, which can serve as a sort of build instructions for people on linux too.
AI Use Disclosure
just for debugging help, not for any actual code writing. i never copy-pasted any ai code into my editor
Related Issues