optimization: remove redundant lastTime setter#1479
Merged
sylvessa merged 1 commit intosmartcmd:mainfrom Apr 5, 2026
Merged
Conversation
itsRevela
pushed a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes a redundant line introduced in #1423. This causes lag on weaker hardware (such as laggy block removing, etc).
Tested on a laptop I have
Changes
Previous Behavior
In minecraftserver::run,
lastTime = getCurrentTimeMillis();would be ran after each tick.RustDesk_07Hv8eNSIH.mp4
Root Cause
Accidental bug introduction, user thought chunk redstone speedup was caused by a bug but instead was just 4j's weird math.
New Behavior
No more
lastTime = getCurrentTimeMillis();. It doesn't break anything regarding tick persistence.RustDesk_3FYpue8inG.mp4
This also did boost my fps a little bit too
Fix Implementation
Remove
lastTime = getCurrentTimeMillis();AI Use Disclosure
None
Related Issues