Adding aptos service implementation by yashnevatia · Pull Request #340 · smartcontractkit/chainlink-aptos

yashnevatia · 2026-02-16T16:47:53Z

relayer/aptos_service.go

+
+		balance, err := client.AccountAPTBalance(addr)
+		if err != nil {
+			s.logger.Warnw("failed to get balance for account, skipping", "account", account, "address", addr.String(), "error", err)


relayer/txm/txm.go

…-aptos into aptos-service

relayer/txm/txm.go

+
+	acc := utils.Ed25519PublicKeyToAddress(ed25519PublicKey)
+	fromAddress := acc.String()
+	a.baseLogger.Infow("TestingAptosWriteCap: EnqueueCRE - resolved from address", "fromAddress", fromAddress)


To fix the issue, avoid logging the full fromAddress value derived from authKey, or log only a non-sensitive, obfuscated version. This preserves functionality while preventing clear-text storage of potentially sensitive account identifiers.

The best low-impact fix is to change the log statement at line 281 in relayer/txm/txm.go to either (a) omit the address value entirely, or (b) log only a truncated/masked version (for example, first/last few characters) that is sufficient for debugging but useless for an attacker. No other logic relies on this log output, so we do not need to change any control flow or data structures.

Concretely, in relayer/txm/txm.go:

Replace the existing Infow call that logs "fromAddress", fromAddress with a version that either:

does not include the "fromAddress" key at all, or

logs an obfuscated string constructed from fromAddress, such as a prefix and suffix plus a length.

This can be done inline without new imports. For example:

maskedFromAddress := fromAddress[:6] + "..." + fromAddress[len(fromAddress)-4:]

Then log "fromAddress", maskedFromAddress.

Ensure we only modify the logging, leaving subsequent parsing of fromAddress and transaction creation unchanged.

No new methods or external libraries are required; this is a simple string manipulation in the existing file.

relayer/txm/txm.go

+	fromAccountAddress := &aptos.AccountAddress{}
+	err = fromAccountAddress.ParseStringRelaxed(fromAddress)
+	if err != nil {
+		a.baseLogger.Errorw("TestingAptosWriteCap: EnqueueCRE - failed to parse from address", "fromAddress", fromAddress, "error", err)


To fix the issue, we should avoid logging the full fromAddress value directly. Instead, we can either (a) omit it entirely from logs, or (b) log only a redacted form (for example, the first and last few characters), which is enough for debugging while not exposing the complete derived auth key. This addresses the CodeQL concern about clear-text logging of sensitive data without changing any functional behavior of the transaction processing.

The most targeted, non-invasive fix is:

Keep computing fromAddress as before and using it for parsing and transaction construction.

Change the two log statements that include "fromAddress", fromAddress to instead include a redacted value, e.g. RedactAddress(fromAddress).

Implement a small helper RedactAddress in relayer/utils/address.go that takes an address string and returns a redacted representation (e.g. 0x1234...abcd), falling back sensibly for short strings. This keeps logic centralized and reusable.

Use only standard library functionality in the helper to avoid extra dependencies.

Concretely:

In relayer/utils/address.go, add a new helper function RedactAddress(addr string) string after the existing functions.

In relayer/txm/txm.go, update:

The info log at line 281 to log "fromAddress", utils.RedactAddress(fromAddress) instead of the full address.

The error log at line 286 similarly to log the redacted address instead of the full one.

No changes are required to imports beyond using the already imported github.com/smartcontractkit/chainlink-aptos/relayer/utils in txm.go. The new helper in address.go uses only len and string slicing, so no new imports are necessary there.

relayer/txm/txm.go

+
+	select {
+	case a.broadcastChan <- transactionID:
+		ctxLogger.Infow("TestingAptosWriteCap: EnqueueCRE - tx enqueued to broadcast channel", "fromAddr", fromAddress, "transactionID", transactionID)


In general, to fix clear-text logging of sensitive information, you either (1) remove the sensitive data from logs entirely, or (2) obfuscate/redact it so logs retain usefulness without exposing full values. Here, the sensitive value is fromAddress, an account address string derived from an auth key. The safest change that preserves existing functionality is to stop logging the full fromAddress while leaving all transaction processing logic intact.

The single best fix is to modify the log line on line 325 in relayer/txm/txm.go so it no longer includes "fromAddr", fromAddress. Since the rest of the system may depend on this log message existing (e.g., for debugging or metrics parsing), we keep the log but only report non-sensitive fields like transactionID. There is already another log earlier (resolved from address) that also logs fromAddress; ideally that should also be adjusted, but the CodeQL alert specifically highlights line 325, so we will minimally fix that sink. No new imports or helpers are required; we simply adjust the arguments to Infow in the same file.

Concretely:

In relayer/txm/txm.go, locate the select block where the transaction ID is sent on a.broadcastChan.

Replace the Infow call on line 325 to remove the "fromAddr", fromAddress key/value pair, leaving just the message and "transactionID", transactionID.

No additional methods, types, or configuration are needed.

Adding aptos service implementation

eac7f5c

yashnevatia requested a review from a team as a code owner February 16, 2026 16:47

github-advanced-security bot found potential problems Feb 16, 2026

View reviewed changes

yashnevatia added 2 commits February 17, 2026 12:11

Adding EnqueueCRE test, cannot run locally, trying on CI

4283546

Merge branch 'develop' of ssh://github.com/smartcontractkit/chainlink…

e5b0369

…-aptos into aptos-service

yashnevatia had a problem deploying to integration February 17, 2026 12:17 — with GitHub Actions Error

tidy

3ce182f

yashnevatia had a problem deploying to integration February 17, 2026 12:22 — with GitHub Actions Error

tidy

55d4e2c

yashnevatia temporarily deployed to integration February 17, 2026 12:32 — with GitHub Actions Inactive

function name

c7c93d0

yashnevatia temporarily deployed to integration February 17, 2026 13:17 — with GitHub Actions Inactive

wait for cre txs

9bee276

yashnevatia temporarily deployed to integration February 17, 2026 13:42 — with GitHub Actions Inactive

adding serialised params

aafdb92

yashnevatia temporarily deployed to integration February 17, 2026 14:08 — with GitHub Actions Inactive

yashnevatia added 7 commits February 17, 2026 20:21

clean

e180775

wip

517566a

forwarder comments

1bbc29e

wip

abfd050

comments

01d90e1

adding beholder monitoring to aptos txm

8731df5

bump common to main

7979213

yashnevatia marked this pull request as draft March 5, 2026 18:51

yashnevatia requested a review from Fletch153 March 6, 2026 10:09

support for hash and status

c254a66

github-advanced-security bot found potential problems Mar 6, 2026

View reviewed changes

yashnevatia added 3 commits March 9, 2026 10:01

wip

d01ecbb

wip: 2026-03-09T11:26:56

a0ac81d

wip: 2026-03-09T12:24:41

dfe4213

@@ -67,3 +67,14 @@
             	return Ed25519PublicKeyToAddress(ed25519.PublicKey(publicKey)), nil
             }
+            // RedactAddress returns a partially obfuscated representation of an address string
+            // suitable for logging without exposing the full underlying value.
+            func RedactAddress(addr string) string {
+            	const keep = 6
+            	n := len(addr)
+            	if n <= 2*keep {
+            		return addr
+            	}
+            	return addr[:keep] + "..." + addr[n-keep:]
+            }

@@ -322,7 +322,7 @@
             	select {
             	case a.broadcastChan <- transactionID:
-            		ctxLogger.Infow("TestingAptosWriteCap: EnqueueCRE - tx enqueued to broadcast channel", "fromAddr", fromAddress, "transactionID", transactionID)
+            		ctxLogger.Infow("TestingAptosWriteCap: EnqueueCRE - tx enqueued to broadcast channel", "transactionID", transactionID)
             	default:
             		// if the channel is full, we drop the transaction.
             		// we do this instead of setting the tx in `a.transactions` post-broadcast to avoid a race

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding aptos service implementation#340

Adding aptos service implementation#340
yashnevatia wants to merge 19 commits intodevelopfrom
aptos-service

yashnevatia commented Feb 16, 2026 •

edited

Loading

Uh oh!

Check failure

Copilot Autofix

Uh oh!

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

yashnevatia commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check failure

Uh oh!

Copilot Autofix

Uh oh!

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

yashnevatia commented Feb 16, 2026 •

edited

Loading