Refactor ContractWriter.SubmitTransaction to single request struct

[Fletch153]

Summary

• Replace 8 positional parameters on ContractWriter.SubmitTransaction with a single SubmitTransactionRequest struct
• Adding a field to a struct is backwards-compatible; adding a parameter to a function signature is not
• Prepares for SimulationOptions PR (PLEX-2604) which will add SimulationOptions as a struct field

Changes (4 files)

• pkg/types/contract_writer.go — Add SubmitTransactionRequest struct, update interface signature
• pkg/loop/internal/relayer/pluginprovider/contractwriter/contract_writer.go — Update gRPC Client and Server
• pkg/types/interfacetests/utils.go — Update test helper call sites
• pkg/loop/internal/relayer/pluginprovider/contractreader/contract_reader_test.go — Update fakeContractWriter

What's NOT changed

• Proto files — wire format unchanged
• Chain-specific interfaces (EVM, Solana, Aptos) — separate SubmitTransaction on different types
• GetEstimateFee — separate concern, separate PR
• No mock regeneration needed — .mockery.yaml doesn't include ContractWriter

Breaking Change

ContractWriter.SubmitTransaction signature changed. All downstream implementors (chainlink-evm, chainlink-solana, chainlink-aptos, etc.) will need corresponding updates when bumping this dependency.

Test plan

• go build ./... — clean
• go test ./pkg/types/... — pass
• go test ./pkg/loop/internal/relayer/pluginprovider/... — pass
• Grep confirms no remaining callers use old positional signature

[github-actions]

👋 Fletch153, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (1)

pkg/types.ContractWriter (1)

• SubmitTransaction — Type changed:

func(
  context.Context, 
  - string, 
  - string, 
  - any, 
  - IdempotencyKey, 
  - string, 
  - *TxMeta, 
  - *math/big.Int
  + SubmitTransactionRequest
)
error

✅ Compatible Changes (1)

pkg/types (1)

• SubmitTransactionRequest — ➕ Added

---

📄 View full apidiff report

[Fletch153]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}