Conversation
jmank88
force-pushed
the
logger-stack-traces
branch
3 times, most recently
from
7bdbe24 to
b85ea61
Compare
jmank88
force-pushed
the
logger-stack-traces
branch
from
b85ea61 to
57002c0
Compare
dhaidashenko
previously approved these changes
Mar 5, 2026
jmank88
force-pushed
the
logger-stack-traces
branch
3 times, most recently
from
2b9df95 to
4684cea
Compare
jmank88
force-pushed
the
logger-stack-traces
branch
from
4684cea to
489eeda
Compare
dhaidashenko
approved these changes
Mar 5, 2026
poopoothegorilla
approved these changes
Mar 5, 2026
ilija42
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes dropping stack traces from
MultiNodelogs at error and critical level, since they are noisy and unhelpful (they are about how the goroutine was launched, not the error condition being reported).Requires: