Skip to content

[CRE-2129] Engine Feature Flags#21341

Merged
bolekk merged 1 commit intodevelopfrom
bugfix_execution_id
Mar 2, 2026
Merged

[CRE-2129] Engine Feature Flags#21341
bolekk merged 1 commit intodevelopfrom
bugfix_execution_id

Conversation

@bolekk
Copy link
Contributor

@bolekk bolekk commented Feb 28, 2026

No description provided.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link

trunk-io bot commented Feb 28, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@bolekk bolekk changed the title [CRE-1794] Execution IDs compatible with multi-triggers [CRE-2129] Engine Feature Flags Feb 28, 2026
trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

@Moses-main
Copy link

Hi team,

I'll work on the Engine Feature Flags. I have experience with configuration management and feature flags in production systems.

Let me know!

Copy link

@trunk-io trunk-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test Results: Dependency Concurrency Issue

Affected failures:

  1. Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_aptos_token_transfer_test.go:Test_CCIP_TokenTransfer_BnM_EVM2Aptos

What Broke

The updated chainlink-common dependency, combined with the new feature flag and limiter logic, introduced a race condition leading to concurrent map writes in the chainlink-aptos module.

Proposed Fixes

Revert the chainlink-common dependency to its previous version to resolve the incompatibility that introduced a race condition in chainlink-aptos.

In go.mod:49

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443

In go.sum:1610

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144 h1:XKvx3xnke2K7/5z6rM/r5k8kE1hWriDm8V/f2TKC/b4=
- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443 h1:13rc5e14/qLMzj6ib0FZkbggXUCL4fgAZ0f/RZAkzvg=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=

In go.mod:46

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443

In go.sum:1373

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144 h1:XKvx3xnke2K7/5z6rM/r5k8kE1hWriDm8V/f2TKC/b4=
- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443 h1:13rc5e14/qLMzj6ib0FZkbggXUCL4fgAZ0f/RZAkzvg=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=

In go.mod:87

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443

In go.sum:1183

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144 h1:XKvx3xnke2K7/5z6rM/r5k8kE1hWriDm8V/f2TKC/b4=
- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443 h1:13rc5e14/qLMzj6ib0FZkbggXUCL4fgAZ0f/RZAkzvg=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=

In go.mod:53

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443

In go.sum:1617

- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144 h1:XKvx3xnke2K7/5z6rM/r5k8kE1hWriDm8V/f2TKC/b4=
- github.com/smartcontractkit/chainlink-common v0.10.1-0.20260302172713-40eba758f144/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443 h1:13rc5e14/qLMzj6ib0FZkbggXUCL4fgAZ0f/RZAkzvg=
+ github.com/smartcontractkit/chainlink-common v0.10.1-0.20260227202051-0f1cea05d443/go.mod h1:0ghbAr7tRO0tT5ZqBXhOyzgUO37tNNe33Yn0hskauVM=
Autofix Options

You can apply the proposed fixes directly to your branch. Try the following:

  • Comment /trunk stack-fix GeUjHl2z to generate a stacked PR with the proposed fixes.
  • Use MCP in your IDE to fix the issue. Try Help me fix CI failures from GeUjHl2z to get started.

View all test uploads

@cl-sonarqube-production
Copy link

Copy link

@trunk-io trunk-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test Results: Unrelated Failure

Affected failures:

  1. Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_Solana2EVM_LOOPP

What Broke

This failure appears to be unrelated to the changes in this PR. The root cause of the CI failure is an incompatible change introduced by the github.com/smartcontractkit/chainlink-common dependency update, which affects the generation or verification of CCIP commit reports. The CI failure is a timeout in a CCIP messaging integration test, specifically while waiting for a commit report. The PR updates the github.com/smartcontractkit/chainlink-common dependency, which is a core library for CCIP components, and changes within this dependency are the most probable cause for the altered behavior of commit report generation or verification.

Autofix Options

You can use our MCP server to get AI assistance with debugging and fixing these failures.

  • Use MCP in your IDE to debug the issue. Try Help me fix CI failures from sKGxeEti to get started.

Tip

Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.

@bolekk bolekk closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants