Fix #21004: Enforce TLS 1.2 as minimum for shell HTTP client#21347
Open
R-Panic wants to merge 2 commits intosmartcontractkit:developfrom
Open
Fix #21004: Enforce TLS 1.2 as minimum for shell HTTP client#21347R-Panic wants to merge 2 commits intosmartcontractkit:developfrom
R-Panic wants to merge 2 commits intosmartcontractkit:developfrom
Conversation
- Added MinVersion: tls.VersionTLS12 to TLSClientConfig in newHttpClient - Protects against downgrade attacks and vulnerabilities in TLS 1.0/1.1 - Maintains backward compatibility with secure TLS 1.2+ connections - Does not affect InsecureSkipVerify flag behavior Fixes smartcontractkit#21004
jmank88
previously approved these changes
Mar 1, 2026
|
Hi team, I'll help enforce TLS 1.2 as minimum for the HTTP client. This is an important security hardening fix. Let me know if I can proceed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21004
Summary
Updated
newHttpClientto explicitly enforce TLS 1.2 as the minimum supported version, ensuring a consistent and secure communication baseline.Changes
MinVersion: tls.VersionTLS12toTLSClientConfiginnewHttpClientfunctionInsecureSkipVerifyflag behavior for testing scenariosSecurity Impact
By enforcing TLS 1.2 as the minimum version, the shell HTTP client:
Testing
No functional changes to existing behavior - only affects handshake negotiation to reject insecure TLS versions.