Skip to content

Logtrigger ACK System E2E Testing#21495

Merged
DylanTinianov merged 88 commits intodevelopfrom
CRE-2178-e2e-logtrigger-acks
Mar 12, 2026
Merged

Logtrigger ACK System E2E Testing#21495
DylanTinianov merged 88 commits intodevelopfrom
CRE-2178-e2e-logtrigger-acks

Conversation

@DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Mar 11, 2026 •
edited
Loading

Extends EVM Log Trigger E2E tests (using local CRE) with ACK system verification via trigger event store persistence.

  • Handles any topology for local / remote trigger capabilities; reads from corresponding wf or capability node DB.
  • Fixes existing bug in EVMLogTriggerTest when multiple evm chains are active. It was looking for the same message from workflows, and skipped the second chain due to stale logs coming from the same Chip sink for reading workflow messages.

Requires

TriggerEventStore LOOP gRPC Server

@DylanTinianov
Add MethodTriggerEventAck
f47800d
@DylanTinianov
Add ackKey
96711cd
@DylanTinianov
Update DON2DON
6d5850a
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
e9f89db 
… into PLEX-1460-delivery-acks
@DylanTinianov
Bump common
33bedcb
@DylanTinianov
Add AckEvent
37773c9
@DylanTinianov
Use metadata for acks
58228ff
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
5f82379 
… into PLEX-1460-delivery-acks
@DylanTinianov
Bump common
b474420
@DylanTinianov
Generate
603bff5
@DylanTinianov
Bump common
afa3a26
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
0ee2696 
… into PLEX-1460-delivery-acks
@DylanTinianov
Bump common
48cd7f2
@DylanTinianov
Update combined_client.go
ff2113d
@DylanTinianov
Fix AckEvent
46b2887
@DylanTinianov
Update
375d76f
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
345a2d4 
… into PLEX-1460-delivery-acks
@DylanTinianov
Fix AckEvent
eea15a4
@DylanTinianov
Improve logging
82774a6
@DylanTinianov
Fix AckEvent
8faf3e2
@DylanTinianov
Update fake_trigger.go
76697da
@DylanTinianov
AckEvent
f91717a
@DylanTinianov
Add logging
fa47e9d
@DylanTinianov
Update test logs
079f66c
@DylanTinianov
Add log
a0a0b8a
@DylanTinianov
Update launcher.go
0ac4afa
@DylanTinianov
tests logs
dc7d1d6
@DylanTinianov
Update engine.go
a7424b1
@DylanTinianov
Update engine.go
0d760f7
@DylanTinianov
Test logs
35e4884
fernandezlautaro
fernandezlautaro reviewed Mar 12, 2026
View reviewed changes
@DylanTinianov DylanTinianov marked this pull request as ready for review March 12, 2026 19:57
@DylanTinianov DylanTinianov requested review from a team as code owners March 12, 2026 19:57
@DylanTinianov DylanTinianov enabled auto-merge March 12, 2026 19:57
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Mar 12, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@DylanTinianov DylanTinianov added this pull request to the merge queue Mar 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2026
@DylanTinianov DylanTinianov added this pull request to the merge queue Mar 12, 2026
Merged via the queue into develop with commit 1784d6b Mar 12, 2026
317 of 322 checks passed
@DylanTinianov DylanTinianov deleted the CRE-2178-e2e-logtrigger-acks branch March 12, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@fernandezlautaro fernandezlautaro fernandezlautaro approved these changes

@ChrisAmora ChrisAmora Awaiting requested review from ChrisAmora

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

@nolag nolag Awaiting requested review from nolag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DylanTinianov @jmank88 @fernandezlautaro