Skip to content

Conversation

@dev-dist
Copy link
Collaborator

@dev-dist dev-dist commented Nov 17, 2025

Prevents users from accessing networks with zero visible feeds by making the mainnet/testnet toggle respect hidden feed flags. Additionally, refactors feed visibility logic to eliminate code duplication between components.

Changes

  • Extract and centralize feed visibility logic into shared utility function (feedVisibility.ts)
  • Refactor MainnetTable and TestnetTable to use shared logic, eliminating code duplication
  • Update availableNetworkTypes computation to check for at least one visible feed before enabling network toggle
  • Network toggles now disabled when all feeds are hidden
  • Improve code maintainability with structured comments in visibility logic

@dev-dist dev-dist requested a review from a team as a code owner November 17, 2025 04:19
@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
documentation Ready Ready Preview Dec 1, 2025 11:43pm

@github-actions
Copy link
Contributor

👋 dev-dist, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@dev-dist dev-dist changed the title Tables: isFeedVisible() utility Feed Lists: isFeedVisible() utility Nov 17, 2025
@dev-dist dev-dist merged commit 790dc26 into main Dec 2, 2025
22 checks passed
@dev-dist dev-dist deleted the chainselector-feedlist-hidden-feed-logic branch December 2, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants