Skip to content

chore(codegen): generate config iterations with const #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
Merged

chore(codegen): generate config iterations with const #1798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions private/my-local-model-schema/src/XYZServiceClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,15 +245,15 @@ export class XYZServiceClient extends __Client<
readonly config: XYZServiceClientResolvedConfig;

constructor(...[configuration]: __CheckOptionalClientConfig<XYZServiceClientConfig>) {
let _config_0 = __getRuntimeConfig(configuration || {});
const _config_0 = __getRuntimeConfig(configuration || {});
super(_config_0 as any);
this.initConfig = _config_0;
let _config_1 = resolveClientEndpointParameters(_config_0);
let _config_2 = resolveRetryConfig(_config_1);
let _config_3 = resolveEndpointConfig(_config_2);
let _config_4 = resolveEndpointRequiredConfig(_config_3);
let _config_5 = resolveEventStreamSerdeConfig(_config_4);
let _config_6 = resolveHttpAuthSchemeConfig(_config_5);
const _config_1 = resolveClientEndpointParameters(_config_0);
const _config_2 = resolveRetryConfig(_config_1);
const _config_3 = resolveEndpointConfig(_config_2);
const _config_4 = resolveEndpointRequiredConfig(_config_3);
const _config_5 = resolveEventStreamSerdeConfig(_config_4);
const _config_6 = resolveHttpAuthSchemeConfig(_config_5);
let _config_7 = resolveRuntimeExtensions(_config_6, configuration?.extensions || []);
this.config = _config_7;
this.middlewareStack.use(getSchemaSerdePlugin(this.config));
Expand Down
2 changes: 1 addition & 1 deletion private/my-local-model-schema/src/auth/httpAuthExtensionConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type HttpAuthRuntimeConfig = Partial<{
export const getHttpAuthExtensionConfiguration = (
runtimeConfig: HttpAuthRuntimeConfig
): HttpAuthExtensionConfiguration => {
let _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
const _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
let _httpAuthSchemeProvider = runtimeConfig.httpAuthSchemeProvider!;
return {
setHttpAuthScheme(httpAuthScheme: HttpAuthScheme): void {
Expand Down
14 changes: 7 additions & 7 deletions private/my-local-model/src/XYZServiceClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,15 +231,15 @@ export class XYZServiceClient extends __Client<
readonly config: XYZServiceClientResolvedConfig;

constructor(...[configuration]: __CheckOptionalClientConfig<XYZServiceClientConfig>) {
let _config_0 = __getRuntimeConfig(configuration || {});
const _config_0 = __getRuntimeConfig(configuration || {});
super(_config_0 as any);
this.initConfig = _config_0;
let _config_1 = resolveClientEndpointParameters(_config_0);
let _config_2 = resolveRetryConfig(_config_1);
let _config_3 = resolveEndpointConfig(_config_2);
let _config_4 = resolveEndpointRequiredConfig(_config_3);
let _config_5 = resolveEventStreamSerdeConfig(_config_4);
let _config_6 = resolveHttpAuthSchemeConfig(_config_5);
const _config_1 = resolveClientEndpointParameters(_config_0);
const _config_2 = resolveRetryConfig(_config_1);
const _config_3 = resolveEndpointConfig(_config_2);
const _config_4 = resolveEndpointRequiredConfig(_config_3);
const _config_5 = resolveEventStreamSerdeConfig(_config_4);
const _config_6 = resolveHttpAuthSchemeConfig(_config_5);
let _config_7 = resolveRuntimeExtensions(_config_6, configuration?.extensions || []);
this.config = _config_7;
this.middlewareStack.use(getRetryPlugin(this.config));
Expand Down
2 changes: 1 addition & 1 deletion private/my-local-model/src/auth/httpAuthExtensionConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type HttpAuthRuntimeConfig = Partial<{
export const getHttpAuthExtensionConfiguration = (
runtimeConfig: HttpAuthRuntimeConfig
): HttpAuthExtensionConfiguration => {
let _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
const _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
let _httpAuthSchemeProvider = runtimeConfig.httpAuthSchemeProvider!;
return {
setHttpAuthScheme(httpAuthScheme: HttpAuthScheme): void {
Expand Down
12 changes: 6 additions & 6 deletions private/smithy-rpcv2-cbor-schema/src/RpcV2ProtocolClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,14 @@ export class RpcV2ProtocolClient extends __Client<
readonly config: RpcV2ProtocolClientResolvedConfig;

constructor(...[configuration]: __CheckOptionalClientConfig<RpcV2ProtocolClientConfig>) {
let _config_0 = __getRuntimeConfig(configuration || {});
const _config_0 = __getRuntimeConfig(configuration || {});
super(_config_0 as any);
this.initConfig = _config_0;
let _config_1 = resolveClientEndpointParameters(_config_0);
let _config_2 = resolveRetryConfig(_config_1);
let _config_3 = resolveEndpointConfig(_config_2);
let _config_4 = resolveEndpointRequiredConfig(_config_3);
let _config_5 = resolveHttpAuthSchemeConfig(_config_4);
const _config_1 = resolveClientEndpointParameters(_config_0);
const _config_2 = resolveRetryConfig(_config_1);
const _config_3 = resolveEndpointConfig(_config_2);
const _config_4 = resolveEndpointRequiredConfig(_config_3);
const _config_5 = resolveHttpAuthSchemeConfig(_config_4);
let _config_6 = resolveRuntimeExtensions(_config_5, configuration?.extensions || []);
this.config = _config_6;
this.middlewareStack.use(getSchemaSerdePlugin(this.config));
Expand Down
2 changes: 1 addition & 1 deletion private/smithy-rpcv2-cbor-schema/src/auth/httpAuthExtensionConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type HttpAuthRuntimeConfig = Partial<{
export const getHttpAuthExtensionConfiguration = (
runtimeConfig: HttpAuthRuntimeConfig
): HttpAuthExtensionConfiguration => {
let _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
const _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
let _httpAuthSchemeProvider = runtimeConfig.httpAuthSchemeProvider!;
return {
setHttpAuthScheme(httpAuthScheme: HttpAuthScheme): void {
Expand Down
12 changes: 6 additions & 6 deletions private/smithy-rpcv2-cbor/src/RpcV2ProtocolClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,14 +269,14 @@ export class RpcV2ProtocolClient extends __Client<
readonly config: RpcV2ProtocolClientResolvedConfig;

constructor(...[configuration]: __CheckOptionalClientConfig<RpcV2ProtocolClientConfig>) {
let _config_0 = __getRuntimeConfig(configuration || {});
const _config_0 = __getRuntimeConfig(configuration || {});
super(_config_0 as any);
this.initConfig = _config_0;
let _config_1 = resolveClientEndpointParameters(_config_0);
let _config_2 = resolveRetryConfig(_config_1);
let _config_3 = resolveEndpointConfig(_config_2);
let _config_4 = resolveEndpointRequiredConfig(_config_3);
let _config_5 = resolveHttpAuthSchemeConfig(_config_4);
const _config_1 = resolveClientEndpointParameters(_config_0);
const _config_2 = resolveRetryConfig(_config_1);
const _config_3 = resolveEndpointConfig(_config_2);
const _config_4 = resolveEndpointRequiredConfig(_config_3);
const _config_5 = resolveHttpAuthSchemeConfig(_config_4);
let _config_6 = resolveRuntimeExtensions(_config_5, configuration?.extensions || []);
this.config = _config_6;
this.middlewareStack.use(getRetryPlugin(this.config));
Expand Down
2 changes: 1 addition & 1 deletion private/smithy-rpcv2-cbor/src/auth/httpAuthExtensionConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type HttpAuthRuntimeConfig = Partial<{
export const getHttpAuthExtensionConfiguration = (
runtimeConfig: HttpAuthRuntimeConfig
): HttpAuthExtensionConfiguration => {
let _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
const _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;
let _httpAuthSchemeProvider = runtimeConfig.httpAuthSchemeProvider!;
return {
setHttpAuthScheme(httpAuthScheme: HttpAuthScheme): void {
Expand Down
6 changes: 3 additions & 3 deletions .../main/java/software/amazon/smithy/typescript/codegen/ServiceBareBonesClientGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,15 +379,15 @@ private void generateConstructor() {

int configVariable = 0;
String initialConfigVar = generateConfigVariable(configVariable);
writer.write("let $L = __getRuntimeConfig(configuration || {});",
writer.write("const $L = __getRuntimeConfig(configuration || {});",
initialConfigVar);
writer.write("super($L as any);", initialConfigVar);
writer.write("this.initConfig = $L;", initialConfigVar);

configVariable++;
writer.addImport("resolveClientEndpointParameters", null,
EndpointsV2Generator.ENDPOINT_PARAMETERS_DEPENDENCY);
writer.write("let $L = $L($L);",
writer.write("const $L = $L($L);",
generateConfigVariable(configVariable),
"resolveClientEndpointParameters",
generateConfigVariable(configVariable - 1));
Expand Down Expand Up @@ -420,7 +420,7 @@ private void generateConstructor() {
}
writer.pushState();
writer.putContext(symbolMap);
writer.write("let $newConfig:L = $resolveFn:T($oldConfig:L" + additionalParamsString + ");");
writer.write("const $newConfig:L = $resolveFn:T($oldConfig:L" + additionalParamsString + ");");
writer.popState();
}
}
Expand Down
2 changes: 1 addition & 1 deletion .../smithy/typescript/codegen/auth/http/integration/HttpAuthRuntimeExtensionIntegration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ private void generateGetHttpAuthExtensionConfigurationFunction(
): HttpAuthExtensionConfiguration => {""", "};",
() -> {
w.addTypeImport("HttpAuthScheme", null, TypeScriptDependency.SMITHY_TYPES);
w.write("let _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;");
w.write("const _httpAuthSchemes = runtimeConfig.httpAuthSchemes!;");
w.addTypeImport(serviceName + "HttpAuthSchemeProvider", null, AuthUtils.AUTH_HTTP_PROVIDER_DEPENDENCY);
w.write("let _httpAuthSchemeProvider = runtimeConfig.httpAuthSchemeProvider!;");
List<ConfigField> mainConfigFields = configFields.values().stream()
Expand Down