Skip to content
This repository was archived by the owner on Oct 23, 2019. It is now read-only.

Refactor core hook logic#475

Draft
linuxdaemon wants to merge 18 commits intosnoonetIRC:gonzobotfrom
linuxdaemon:gonzobot+hook-managers
Draft

Refactor core hook logic#475
linuxdaemon wants to merge 18 commits intosnoonetIRC:gonzobotfrom
linuxdaemon:gonzobot+hook-managers

Conversation

@linuxdaemon
Copy link

@linuxdaemon linuxdaemon commented Mar 22, 2019 •
edited
Loading

Todo

  • Manager objects for each hook type, to handle the launch logic and store registered hooks

@linuxdaemon
Move complete Hook classes to their own modules
5ce297f
@linuxdaemon
Move table and hook loading to Plugin()
51bfa8a
@linuxdaemon
Split out basic hook data objects to subclasses
c106fa3
@linuxdaemon
Refactor hook type logic
da4b934
@linuxdaemon
Add __all__ for hook.py
809d457
@linuxdaemon
Add _Hook.make_full_hook() instead of manual type map
fd4a3be
@linuxdaemon
Move PluginManager to plugin_manager.py
23d8a73
@linuxdaemon
Move plugin whitelist/blacklist logic to function
b72a940
@linuxdaemon
Refactor plugin search logic
cc7f6f0
@linuxdaemon
Move cloudbot data attributes to global vars
708fc16
@linuxdaemon
Refactor plugin load logic
3dc9a52 
Only iterate the objects once, allow creating and loading plugins as
separate stages
@linuxdaemon
Store a reference to the manager on each plugin
0664200
@linuxdaemon
Add BotInstanceHolder.get_or_raise()
f9bff4a
@linuxdaemon
Remove useless super __init__
192122a
@linuxdaemon
Remove unecessary bot import
86d2969
@linuxdaemon
Refactor imports in hook tests
6736f51
@linuxdaemon
Clean up type annotations in bot.py
4c963ef
@linuxdaemon
Clean up hook module imports
e2fe433
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@linuxdaemon