Snow 2306184 ng config support 3 #2638

sfc-gh-mraba · 2025-10-01T13:03:46Z

Pre-review checklist

I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
I've added or updated automated unit tests to verify correctness of my new code.
I've added or updated integration tests to verify correctness of my new code.
I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
I've confirmed that my changes are working by executing CLI's commands manually on Windows.
I've confirmed that my changes are up-to-date with the target branch.
I've described my changes in the release notes.
I've described my changes in the section below.
I've described my changes in the documentation.

Changes description

This PR refactors the Snowflake CLI configuration management by removing the module-level CONFIG_MANAGER singleton and replacing it with a factory-based approach managed through the CliGlobalContext. This change improves testability and eliminates test flakiness caused by shared global state.

src/snowflake/cli/_app/version_check.py

tests/nativeapp/codegen/test_compiler.py

sfc-gh-jwilkowski

I left 1 important question about connections_file_override which does not seem to be needed (maybe yet?). Otherwise a general comment would be about recurring issues across this PR:

lots of local imports, where I don't think most of them would cause circular deps
lots of comments that don't add much value
I've seen this pattern repeating several times - maybe path resolver could go into SecurePath so that we can avoid repeating those?

# Resolve Windows short paths to prevent cleanup issues
resolved_tmp_dir = path_resolver(tmp_dir)
config_path = Path(resolved_tmp_dir) / "config.toml"

Otherwise, looks great!

src/snowflake/cli/_app/loggers.py

src/snowflake/cli/api/cli_global_context.py

src/snowflake/cli/_plugins/helpers/commands.py

sfc-gh-jwilkowski · 2025-12-12T10:52:50Z

src/snowflake/cli/_plugins/helpers/commands.py

+    hidden=os.environ.get(ALTERNATIVE_CONFIG_ENV_VAR, "").lower()
+    not in ("1", "true", "yes", "on"),
+)
+def show_config_sources(


when I'm thinking about this command one of the primary use cases would be "I have connection x defined in different places, how can I see where it's taking it's values from". what do you think about providing --connection flag to serve that instead of key argument?

Maybe in future. This PR is already huge.

then for now I'd only suggest to make key an option not an argument

sfc-gh-jwilkowski · 2025-12-15T08:17:05Z

src/snowflake/cli/_plugins/helpers/commands.py

+        "-d",
+        help="Show detailed resolution chains for all sources consulted.",
+    ),
+    export_file: Optional[Path] = typer.Option(


from what I understood this option and related logic should be removed

sfc-gh-jwilkowski · 2025-12-16T11:03:30Z

src/snowflake/cli/api/config_ng/merge_operations.py

+    Example:
+        Input:
+            connections = {"dev": {"account": "dev_acc", "user": "dev_user"}}
+            params = {"user": "override_user", "password": "new_pass"}
+        Output:
+            {"dev": {"account": "dev_acc", "user": "override_user", "password": "new_pass"}}


This feels confusing, at least I interpreted it as if the top level settings would override what's defined on particular connection level

sfc-gh-jwilkowski · 2025-12-16T11:56:12Z

src/snowflake/cli/api/config_ng/parsers.py

+        return cls._apply_default_connection_fallback(result)
+
+    @classmethod
+    def _apply_default_connection_fallback(


@sfc-gh-mraba here's the logic that actually takes general settings and applies specifics overlay

sfc-gh-jwilkowski · 2025-12-17T13:21:21Z

src/snowflake/cli/api/config_ng/resolver.py

+    def attach_observer(self, observer: ResolutionObserver) -> None:
+        """Attach a new observer at runtime."""
+        self._observers.append(observer)
+        if isinstance(observer, TelemetryObserver):
+            self._telemetry_observer = observer
+        if isinstance(observer, ResolutionHistoryTracker):
+            self._history_observer = observer


This method seems to be redundant. It's only used once in ensure_history_tracking to attach ResolutionHistoryTracker. Those 3 lines might just as well end up in ensure_history_tracking

sfc-gh-jwilkowski · 2025-12-17T13:24:04Z

src/snowflake/cli/api/config_ng/resolver.py

+        Returns:
+            True if a new tracker was attached and observers should be reset.


seems that this return value is needed only for resetting - why not do it in this method? Feels weird when you call ensure_something method and it returns you false even though that thing is ensured

sfc-gh-jwilkowski · 2025-12-17T13:25:20Z

src/snowflake/cli/api/config_ng/resolver.py

+        for observer in self._observers:
+            getattr(observer, method_name)(*args, **kwargs)
+
+    def add_source(self, source: "ValueSource") -> None:


sfc-gh-jwilkowski · 2025-12-17T13:26:00Z

src/snowflake/cli/api/config_ng/resolver.py

+        """
+        return [s for s in self._sources if s.source_type is source_type]
+
+    def _record_discoveries(self, source_values: Dict[str, ConfigValue]) -> None:


…ins test update

…ith sanitisation

…ith sanitisation 2

…quested

…quested - fix win tests

…quested - fix rebase

graphite-app bot reviewed Oct 1, 2025

View reviewed changes

src/snowflake/cli/_app/version_check.py Show resolved Hide resolved

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from 54e7ad4 to 52151dd Compare October 2, 2025 08:37

graphite-app bot reviewed Oct 2, 2025

View reviewed changes

tests/nativeapp/codegen/test_compiler.py Outdated Show resolved Hide resolved

sfc-gh-mraba self-assigned this Oct 2, 2025

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch 2 times, most recently from 99a467d to c32692c Compare October 13, 2025 06:57

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from 68ccdbc to ee5e0ce Compare October 21, 2025 08:42

sfc-gh-mraba marked this pull request as ready for review October 21, 2025 08:43

sfc-gh-mraba requested a review from a team as a code owner October 21, 2025 08:43

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from ee5e0ce to 2484c26 Compare October 21, 2025 12:34

sfc-gh-jwilkowski reviewed Oct 22, 2025

View reviewed changes

src/snowflake/cli/_app/loggers.py Show resolved Hide resolved

src/snowflake/cli/api/cli_global_context.py Outdated Show resolved Hide resolved

src/snowflake/cli/api/cli_global_context.py Show resolved Hide resolved

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from 2484c26 to 66356e5 Compare October 23, 2025 12:57

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from af729e4 to 304a27a Compare November 3, 2025 08:05

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from 304a27a to 927bc4f Compare November 17, 2025 09:10

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch 2 times, most recently from 0454d1a to c02a716 Compare December 2, 2025 12:33

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch 2 times, most recently from 0fa6b1d to 1ee50c4 Compare December 9, 2025 15:27

sfc-gh-mraba requested a review from sfc-gh-jwilkowski December 9, 2025 15:27

sfc-gh-jwilkowski reviewed Dec 12, 2025

View reviewed changes

src/snowflake/cli/_plugins/helpers/commands.py Outdated Show resolved Hide resolved

sfc-gh-jwilkowski reviewed Dec 12, 2025

View reviewed changes

src/snowflake/cli/_plugins/helpers/commands.py Outdated Show resolved Hide resolved

sfc-gh-jwilkowski reviewed Dec 12, 2025

View reviewed changes

sfc-gh-jwilkowski reviewed Dec 15, 2025

View reviewed changes

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from 1ee50c4 to 5d3c16a Compare December 15, 2025 09:07

sfc-gh-jwilkowski reviewed Dec 16, 2025

View reviewed changes

sfc-gh-jwilkowski reviewed Dec 17, 2025

View reviewed changes

sfc-gh-mraba added 27 commits December 22, 2025 08:40

SNOW-2306184: config refactor - remove comments

e63aee4

SNOW-2306184: config refactor - value masking for ResolutionHistory

5b85ad4

SNOW-2306184: config refactor - in memory pk

e47de72

SNOW-2306184: config refactor - ensure file permissions checks

39418f2

SNOW-2306184: config refactor - tests for value masking

6ff8521

SNOW-2306184: config refactor - oauth typo

a3ff4af

SNOW-2306184: config refactor - thread safe singleton

2b06fda

SNOW-2306184: config refactor - try_cast_to_bool compatibility added

1a30419

SNOW-2306184: config refactor - sanitize logging

8283639

SNOW-2306184: config refactor - remove tomli conditional import

3cab1aa

SNOW-2306184: config refactor - test fix

17336f4

SNOW-2306184: config refactor - test fix 2

e46cff4

SNOW-2306184: config refactor - ensure file permissions checks - plug…

3466552

…ins test update

SNOW-2306184: config refactor - top level conn params

99836c3

SNOW-2306184: config refactor - improve performance for key discovery

4355271

SNOW-2306184: config refactor - silent exceptions logged as warning w…

a1cb7b8

…ith sanitisation

SNOW-2306184: config refactor - silent exceptions logged as warning w…

04bb772

…ith sanitisation 2

SNOW-2306184: config refactor - track resolution history only when re…

4cb469b

…quested

SNOW-2306184: config refactor - track resolution history only when re…

e53602a

…quested - fix win tests

SNOW-2306184: config refactor - track resolution history only when re…

9746079

…quested - fix rebase

SNOW-2306184: config refactor - move from Literal to Enum

28da35b

SNOW-2306184: config refactor - SnowSQL default fallback

41621e4

SNOW-2306184: config refactor - asyns queries retries

06a5fd3

SNOW-2306184: config refactor - drop export option

6c40133

SNOW-2306184: config refactor - drop examples

ad9513c

SNOW-2306184: config refactor - helper command cleanup

11a952f

SNOW-2306184: dead code cleanup

b599018

sfc-gh-mraba force-pushed the SNOW-2306184-ng-config-support-3 branch from e8f727c to b599018 Compare December 22, 2025 07:40

sfc-gh-mraba added 2 commits December 22, 2025 10:07

SNOW-2306184: dead code cleanup 2

9ad4ced

SNOW-2306184: dead code cleanup 3

1cbc954

		Returns:
		True if a new tracker was attached and observers should be reset.

Snow 2306184 ng config support 3 #2638

Are you sure you want to change the base?

Snow 2306184 ng config support 3 #2638

Uh oh!

Conversation

sfc-gh-mraba commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-review checklist

Changes description

Uh oh!

Uh oh!

Uh oh!

sfc-gh-jwilkowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sfc-gh-mraba commented Oct 1, 2025 •

edited

Loading