fix(engine.io): add @types/ws as a dependency#5458
Closed
Not-Sarthak wants to merge 2 commits intosocketio:mainfrom
Closed
fix(engine.io): add @types/ws as a dependency#5458Not-Sarthak wants to merge 2 commits intosocketio:mainfrom
Not-Sarthak wants to merge 2 commits intosocketio:mainfrom
Conversation
… throws Remove the `return` in the catch block of ClusterAdapter.broadcast() so that super.broadcast() is still called when remote publishing fails. This ensures local sockets receive the event even if the cluster publish errors out (e.g. due to a serialization error in the adapter layer). Fixes socketio#5456
Since engine.io@6.6.5, the generated .d.ts files import types from "ws" (WebSocket, PerMessageDeflateOptions), but @types/ws was not declared as a dependency. This causes TypeScript compilation errors for consumers who do not have @types/ws installed. This follows the existing pattern where @types/cors and @types/node are already listed as dependencies. Fixes socketio#5437
darrachequesne
pushed a commit
that referenced
this pull request
Mar 4, 2026
Since engine.io@6.6.5, the generated .d.ts files import types from "ws" (WebSocket, PerMessageDeflateOptions), but @types/ws was not declared as a dependency. This causes TypeScript compilation errors for consumers who do not have @types/ws installed. This follows the existing pattern where @types/cors and @types/node are already listed as dependencies. Related: #5437
Member
|
Merged as 07cbe15. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5437
Since engine.io@6.6.5 (commit be13cca), the generated
.d.tsfiles import types from"ws"(WebSocket,PerMessageDeflateOptions), but@types/wswas not declared as a dependency. This causes TypeScript compilation errors for consumers who do not have@types/wsinstalled:The fix adds
@types/wsas a dependency, following the existing pattern where@types/corsand@types/nodeare already listed as dependencies.Test plan
engine.iotests pass (189/189, both default and compat-v3)package.json— no code changes