Skip to content

Delete soda-core/setup.py#2572

Merged
Niels-b merged 2 commits intomainfrom
fix-delete-accidental-file
Feb 9, 2026
Merged

Delete soda-core/setup.py#2572
Niels-b merged 2 commits intomainfrom
fix-delete-accidental-file

Conversation

@paulteehan
Copy link
Copy Markdown
Contributor

@paulteehan paulteehan commented Feb 5, 2026

  • soda-core/setup.py was recently deleted from main (Fix: Remove setup.py from soda-core #2567)
  • Platl 324 fix pydantic issue #2571 was approved but I had to manually resolve a merge conflict on this file
  • I believed I had deleted the file on the merged branch, but I accidentally re-added it, and didn't notice, and merged
  • This PR re-deletes the file, I think that's the cleanest way to undo this

Copy link
Copy Markdown
Contributor

@mivds mivds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to remove setup.py, but I think the pydantic version requirement also still needs updating in soda-core/pyproject.toml. On this branch (and main) it is currently still set to pydantic>=2.0,<3.0

@paulteehan
Copy link
Copy Markdown
Contributor Author

Makes sense to remove setup.py, but I think the pydantic version requirement also still needs updating in soda-core/pyproject.toml. On this branch (and main) it is currently still set to pydantic>=2.0,<3.0

oh how on earth did I muck this up?? Good thing you checked, yikes, will fix

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

@mivds mivds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Niels-b!

@Niels-b Niels-b merged commit 14890e3 into main Feb 9, 2026
41 checks passed
@Niels-b Niels-b deleted the fix-delete-accidental-file branch February 9, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants