Adding FailedRowProcessor support in soda-spark#114
Open
joaoluga wants to merge 7 commits intosodadata:mainfrom
Open
Adding FailedRowProcessor support in soda-spark#114joaoluga wants to merge 7 commits intosodadata:mainfrom
joaoluga wants to merge 7 commits intosodadata:mainfrom
Conversation
added 3 commits
June 1, 2022 13:55
- Allowing users to use the FailedRowsProcessor feature by passing it in the execute method
Contributor
|
Thanks @joaoluga for the PR. Could you add a test for the failed rows processor? |
Author
hey @JCZuurmond, sorry for taking so long. Yes and I've just included the tests for the failed row processor just now. 😁 |
JCZuurmond
suggested changes
Jun 22, 2022
Contributor
JCZuurmond
left a comment
There was a problem hiding this comment.
I have a couple suggestions
tests/test_scan.py
Outdated
| class InMemoryFailedRowProcessor(FailedRowsProcessor): | ||
| def process(self, context: dict) -> dict: | ||
|
|
||
| try: |
Contributor
There was a problem hiding this comment.
This try except does not do anything, right?
Author
There was a problem hiding this comment.
Yes, you are correct. I was just following the pattern I found in this doc 😅 Just changed the except to throw the exception 🤔
JCZuurmond
approved these changes
Jun 23, 2022
Contributor
JCZuurmond
left a comment
There was a problem hiding this comment.
LGTM. @vijaykiran could you give a final go?
Contributor
|
Thank you @joaoluga and @JCZuurmond - LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #113
snippet:
expected output: